From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54F3C32772 for ; Tue, 23 Aug 2022 20:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233706AbiHWUG1 (ORCPT ); Tue, 23 Aug 2022 16:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233671AbiHWUGG (ORCPT ); Tue, 23 Aug 2022 16:06:06 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD51A5FA1 for ; Tue, 23 Aug 2022 12:22:50 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id x63-20020a17090a6c4500b001fabbf8debfso15677160pjj.4 for ; Tue, 23 Aug 2022 12:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=vluVKO5NRnQyzyhQUGPfMvMjb6neCROySKrkY1xAivk=; b=RFpneXhBxHQqMg0kLtL1zDCS6S1gC3zkpuQU512oHuvBG+thV13/Uz2ISEDeYuBiqM aGvSBuo+ONVzOIxbkx/SWFVmfK1YtaVx7n5yiomDC7o3JODhVP3wWul6vOytOuyuQk3X ov6AqvXv6EJ5D8a04bCGgg4Vn9eBwVzMSXHMwZ0/FCs2R56Zj9JjErTF0QtxdLiJGRHt aSg9MprO91J2uk8MCX64z1mLGpDRIkWe6dEfBTJ9s+qO3qURaRXvsOxeEuq6uYCR+jxC daPdllVVFosoOaM7ewD0uO85ckP+/3r2ZE8f+4Jf1wogjxpfwQPIQu6huaOeaTK2YnG7 1gYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=vluVKO5NRnQyzyhQUGPfMvMjb6neCROySKrkY1xAivk=; b=INhVUDEeNZV1otJNIss+zvc0gxEecnp21T1OjIy2tU+8D/AQ2vMtopC/vTzU914NLU 4s5PE9Ni4yJQqVZxIES73IYAJqYXcRfbYAPFgWO5qn2zJ0XdDe6D4/9DF9AqR2KPGQrs aTQPiyfqWpM5BwZz5HbGAWDe9O0xCFInpbIWBzrCntAjVORjJk5nzsJuuegW62xYQ/MU R/wTvbuI8Df8zccjX9XdVgH7Wab6AzfVwsIRRFcaIy65q8w9/8ZJF9+sUnQrvVx5OJjB 0p8jveIb0MfjcCVgRsyAAUrZUeycHGbZJXE0fIlq7Tkx09cr/1HpZSMsHxkWcrWljGVp Q4cA== X-Gm-Message-State: ACgBeo2VnOd8hLnMhTq0p942fO6xy5i2moJQ19kWBV8gf2uIUC0JFsVZ jG+++W6jWToykVJvTx2BZa9/jA== X-Google-Smtp-Source: AA6agR6N2D2LqxwUPxnm1OVswfxuCieBbCam/Vy4PEiUjzbJ649yVF+yAFBnMC+7aRyrmSfb6NDHsw== X-Received: by 2002:a17:902:e809:b0:172:eded:e879 with SMTP id u9-20020a170902e80900b00172edede879mr9633105plg.54.1661282570371; Tue, 23 Aug 2022 12:22:50 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id p63-20020a634242000000b004291cb9c047sm9556130pga.87.2022.08.23.12.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 12:22:49 -0700 (PDT) Date: Tue, 23 Aug 2022 13:22:47 -0600 From: Mathieu Poirier To: Christophe JAILLET Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , Richard Zhu , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Mathieu Poirier , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] remoteproc: imx_rproc: Simplify some error message Message-ID: <20220823192247.GA1781852@p14s> References: <6b9343c2688117a340661d8ee491c2962c54a09a.1659736936.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b9343c2688117a340661d8ee491c2962c54a09a.1659736936.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 06, 2022 at 12:02:32AM +0200, Christophe JAILLET wrote: > dev_err_probe() already prints the error code in a human readable way, so > there is no need to duplicate it as a numerical value at the end of the > message. > > While at it, remove 'ret' that is mostly useless. > > Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox") > Signed-off-by: Christophe JAILLET > --- > drivers/remoteproc/imx_rproc.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 38383e7de3c1..7cc4fd207e2d 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -646,7 +646,6 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc) > struct imx_rproc *priv = rproc->priv; > struct device *dev = priv->dev; > struct mbox_client *cl; > - int ret; > > if (!of_get_property(dev->of_node, "mbox-names", NULL)) > return 0; > @@ -659,18 +658,15 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc) > cl->rx_callback = imx_rproc_rx_callback; > > priv->tx_ch = mbox_request_channel_byname(cl, "tx"); > - if (IS_ERR(priv->tx_ch)) { > - ret = PTR_ERR(priv->tx_ch); > - return dev_err_probe(cl->dev, ret, > - "failed to request tx mailbox channel: %d\n", ret); > - } > + if (IS_ERR(priv->tx_ch)) > + return dev_err_probe(cl->dev, PTR_ERR(priv->tx_ch), > + "failed to request tx mailbox channel\n"); > > priv->rx_ch = mbox_request_channel_byname(cl, "rx"); > if (IS_ERR(priv->rx_ch)) { > mbox_free_channel(priv->tx_ch); > - ret = PTR_ERR(priv->rx_ch); > - return dev_err_probe(cl->dev, ret, > - "failed to request rx mailbox channel: %d\n", ret); > + return dev_err_probe(cl->dev, PTR_ERR(priv->rx_ch), > + "failed to request rx mailbox channel\n"); > } > > return 0; > -- > 2.34.1 >