From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA1CC00140 for ; Wed, 24 Aug 2022 09:44:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235585AbiHXJo0 (ORCPT ); Wed, 24 Aug 2022 05:44:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235102AbiHXJoI (ORCPT ); Wed, 24 Aug 2022 05:44:08 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91B495AC6; Wed, 24 Aug 2022 02:44:05 -0700 (PDT) Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4MCLl70cF2z688sd; Wed, 24 Aug 2022 17:43:47 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 24 Aug 2022 11:44:03 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 24 Aug 2022 10:44:02 +0100 Date: Wed, 24 Aug 2022 10:44:01 +0100 From: Jonathan Cameron To: Davidlohr Bueso CC: Adam Manzanares , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "widawsk@kernel.org" , "dan.j.williams@intel.com" , "linux-cxl@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] cxl: Replace HDM decoder granularity magic numbers Message-ID: <20220824104401.00005cd4@huawei.com> In-Reply-To: <20220822171703.sfizbmn6retpxggi@offworld> References: <20220822170510.125082-1-a.manzanares@samsung.com> <20220822171703.sfizbmn6retpxggi@offworld> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Aug 2022 10:17:03 -0700 Davidlohr Bueso wrote: > On Mon, 22 Aug 2022, Adam Manzanares wrote: > > >When reviewing the CFMWS parsing code that deals with the HDM decoders, > >I noticed a couple of magic numbers. This commit replaces these magic numbers > >with constants defined by the CXL 2.0 specification. > > Please use 3.0 spec :) > > Actually the whole drivers/cxl/* could use updating the comments for 3.0. Interesting point. What do we want to do on this? Most similar cases I've been involved on rely on referring to 'oldest' compatible spec. (this is true for ACPI stuff for example). I don't care either way, but a policy on this will save us some time by ensuring we meet that policy before sending for review. Jonathan