Re: [PATCH] x86/sev: Mark snp_abort() noreturn

Nick Desaulniers
2022-08-24T18:44:55Z

On Wed, Aug 24, 2022 at 10:33 AM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> Hi!
>
> On Wed, Aug 24, 2022 at 05:24:20PM +0200, Borislav Petkov wrote:
> > Mark both the function prototype and definition as noreturn in order to
> > prevent the compiler from doing transformations which confuse objtool
> > like so:
> >
> > vmlinux.o: warning: objtool: sme_enable+0x71: unreachable instruction
>
> Would -Wmissing-noreturn have caught this?

Oh, that's shiny. Is that relatively new?
--
Thanks,
~Nick Desaulniers