Re: [PATCH v3] net: dsa: mv88e6xxx: support RGMII cmode

Marek Behún
2022-08-25T22:06:20Z

On Thu, 25 Aug 2022 12:38:07 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Mon, 22 Aug 2022 16:41:36 +0200 Marcus Carlberg wrote:
> > Since the probe defaults all interfaces to the highest speed possible
> > (10GBASE-X in mv88e6393x) before the phy mode configuration from the
> > devicetree is considered it is currently impossible to use port 0 in
> > RGMII mode.
> >
> > This change will allow RGMII modes to be configurable for port 0
> > enabling port 0 to be configured as RGMII as well as serial depending
> > on configuration.
> >
> > Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")
> > Signed-off-by: Marcus Carlberg <marcus.carlberg@axis.com>
>
> Seems like a new configuration which was not previously supported
> rather than a regression, right? If so I'll drop the Fixes tag
> when applying.

Please leave the fixes tag. This configuration should have been
supported from the beginning.

Marek