[PATCH] crypto: lib - remove unneeded selection of XOR_BLOCKS

[PATCH] crypto: lib - remove unneeded selection of XOR_BLOCKS

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS.  It perhaps
was thought that it's needed for __crypto_xor, but that's not the case.

Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a
benchmark when it is initialized.  That causes a boot time regression on
systems that didn't have it enabled before.

Therefore, remove this unnecessary and problematic selection.

Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
---

I've separated this fix out from the larger patch
https://lore.kernel.org/r/20220725183636.97326-3-ebiggers@kernel.org
that is currently queued in cryptodev.

 lib/crypto/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig
index 9ff549f63540fa..47816af9a9d7e1 100644
--- a/lib/crypto/Kconfig
+++ b/lib/crypto/Kconfig
@@ -33,7 +33,6 @@ config CRYPTO_ARCH_HAVE_LIB_CHACHA
 
 config CRYPTO_LIB_CHACHA_GENERIC
 	tristate
-	select XOR_BLOCKS
 	help
 	  This symbol can be depended upon by arch implementations of the
 	  ChaCha library interface that require the generic code as a

base-commit: 4c612826bec1441214816827979b62f84a097e91
-- 
2.37.2

Re: [PATCH] crypto: lib - remove unneeded selection of XOR_BLOCKS

[Herbert Xu]

On Thu, Aug 25, 2022 at 10:04:56PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS.  It perhaps
> was thought that it's needed for __crypto_xor, but that's not the case.
> 
> Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a
> benchmark when it is initialized.  That causes a boot time regression on
> systems that didn't have it enabled before.
> 
> Therefore, remove this unnecessary and problematic selection.
> 
> Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> 
> I've separated this fix out from the larger patch
> https://lore.kernel.org/r/20220725183636.97326-3-ebiggers@kernel.org
> that is currently queued in cryptodev.
> 
>  lib/crypto/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Patch applied.  Thanks. 
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt