From: Li Zhong <floridsleeves@gmail.com>
To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v2] drivers/tty/serial: check the return value of uart_port_check()
Date: Fri, 26 Aug 2022 01:36:12 -0700 [thread overview]
Message-ID: <20220826083612.1699194-1-floridsleeves@gmail.com> (raw)
uart_port_check() will return NULL pointer when state->uart_port is
NULL. Check the return value before dereference it to avoid
null-pointer-dereference error.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/tty/serial/serial_core.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 12c87cd201a7..760e177166cf 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -194,6 +194,9 @@ static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
unsigned long page;
int retval = 0;
+ if (!uport)
+ return -EIO;
+
if (uport->type == PORT_UNKNOWN)
return 1;
@@ -498,6 +501,8 @@ static void uart_change_speed(struct tty_struct *tty, struct uart_state *state,
struct ktermios *termios;
int hw_stopped;
+ if (!uport)
+ return;
/*
* If we have no tty, termios, or the port does not exist,
* then we can't set the parameters for this port.
@@ -1045,6 +1050,8 @@ static int uart_get_lsr_info(struct tty_struct *tty,
struct uart_port *uport = uart_port_check(state);
unsigned int result;
+ if (!uport)
+ return -EIO;
result = uport->ops->tx_empty(uport);
/*
--
2.25.1
next reply other threads:[~2022-08-26 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 8:36 Li Zhong [this message]
2022-08-26 16:01 ` [PATCH v2] drivers/tty/serial: check the return value of uart_port_check() Andy Shevchenko
2022-08-28 19:57 ` Li Zhong
2022-08-29 7:09 ` Ilpo Järvinen
2022-08-30 6:59 ` Li Zhong
2022-08-30 7:20 ` Ilpo Järvinen
2022-09-03 23:14 ` Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826083612.1699194-1-floridsleeves@gmail.com \
--to=floridsleeves@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox