Re: [PATCH v12 09/17] iommu/vt-d: Add blocking domain support

Baolu Lu
2022-08-28T12:56:09Z

On 2022/8/26 22:54, Jason Gunthorpe wrote:
> On Fri, Aug 26, 2022 at 08:11:33PM +0800, Lu Baolu wrote:
>> The Intel IOMMU hardwares support blocking DMA transactions by clearing
>> the translation table entries. This implements a real blocking domain to
>> avoid using an empty UNMANAGED domain. The detach_dev callback of the
>> domain ops is not used in any path. Remove it to avoid dead code as well.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Tested-by: Tony Zhu <tony.zhu@intel.com>
>> ---
>> drivers/iommu/intel/iommu.c | 25 ++++++++++++++++++-------
>> 1 file changed, 18 insertions(+), 7 deletions(-)
>
> At this point I'd suggest to make a little series that does all the
> blocking domain stuff in one shot
>
> The removal of detach_dev callbacks is pretty nice for clarity.

Yes. As you saw, I have a separated series for above purpose.

Best regards,
baolu