From: Aleksander Jan Bajkowski <olek2@wp.pl>
To: hauke@hauke-m.de, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Aleksander Jan Bajkowski <olek2@wp.pl>
Subject: [PATCH net-next v2 1/1] net: lantiq_xrx200: use skb cache
Date: Sun, 28 Aug 2022 21:19:31 +0200 [thread overview]
Message-ID: <20220828191931.4923-2-olek2@wp.pl> (raw)
In-Reply-To: <20220828191931.4923-1-olek2@wp.pl>
napi_build_skb() reuses NAPI skbuff_head cache in order to save some
cycles on freeing/allocating skbuff_heads on every new Rx or completed
Tx.
Use napi_consume_skb() to feed the cache with skbuff_heads of completed
Tx. The budget parameter is added to indicate NAPI context, as a value
of zero can be passed in the case of netpoll.
NAT performance results on BT Home Hub 5A (kernel 5.15.45, mtu 1500):
Fast path (Software Flow Offload):
Up Down
Before 702.4 719.3
After 707.3 739.9
Slow path:
Up Down
Before 91.8 184.1
After 92.0 185.7
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/ethernet/lantiq_xrx200.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
index 57f27cc7724e..13899720423f 100644
--- a/drivers/net/ethernet/lantiq_xrx200.c
+++ b/drivers/net/ethernet/lantiq_xrx200.c
@@ -239,7 +239,7 @@ static int xrx200_hw_receive(struct xrx200_chan *ch)
return ret;
}
- skb = build_skb(buf, priv->rx_skb_size);
+ skb = napi_build_skb(buf, priv->rx_skb_size);
if (!skb) {
skb_free_frag(buf);
net_dev->stats.rx_dropped++;
@@ -328,7 +328,7 @@ static int xrx200_tx_housekeeping(struct napi_struct *napi, int budget)
pkts++;
bytes += skb->len;
ch->skb[ch->tx_free] = NULL;
- consume_skb(skb);
+ napi_consume_skb(skb, budget);
memset(&ch->dma.desc_base[ch->tx_free], 0,
sizeof(struct ltq_dma_desc));
ch->tx_free++;
--
2.30.2
next prev parent reply other threads:[~2022-08-28 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 19:19 [PATCH net-next v2 0/1] net: lantiq_xrx200: use skb cache Aleksander Jan Bajkowski
2022-08-28 19:19 ` Aleksander Jan Bajkowski [this message]
2022-08-31 19:23 ` [PATCH net-next v2 1/1] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220828191931.4923-2-olek2@wp.pl \
--to=olek2@wp.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox