From: Puyou Lu <puyou.lu@gmail.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Robert Richter <rrichter@cavium.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/gic-v3: do runtime cpu cap check only when necessary
Date: Mon, 29 Aug 2022 11:52:33 +0800 [thread overview]
Message-ID: <20220829035232.GA13376@dell-PowerEdge-T440> (raw)
In-Reply-To: <87r110qong.wl-maz@kernel.org>
On Sun, Aug 28, 2022 at 06:11:15PM +0100, Marc Zyngier wrote:
> Well, what you got wrong is that these instructions are stepped over
> two branches when the caps are finalised, and that doesn't appear in
> the disassembly (you need to look at the code that is actually
> executed).
>
> Now, any optimisation of the sort must be backed by some performance
> numbers. If you can show that this has a meaningful impact on a given
> workload, I'm happy to look into it. But only if you can show that
> data.
>
> Thanks,
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
Thank you very much for correcting me, and sorry for wasting your time, I
got it now.
prev parent reply other threads:[~2022-08-29 3:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 5:19 [PATCH] irqchip/gic-v3: do runtime cpu cap check only when necessary Puyou Lu
2022-08-27 15:13 ` Marc Zyngier
2022-08-28 7:56 ` Puyou Lu
2022-08-28 17:11 ` Marc Zyngier
2022-08-29 3:52 ` Puyou Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829035232.GA13376@dell-PowerEdge-T440 \
--to=puyou.lu@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=rrichter@cavium.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox