From: Sathvika Vasireddy <sv@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: jpoimboe@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, aik@ozlabs.ru, mpe@ellerman.id.au,
mingo@redhat.com, christophe.leroy@csgroup.eu,
rostedt@goodmis.org, mbenes@suse.cz, npiggin@gmail.com,
chenzhongjin@huawei.com, naveen.n.rao@linux.vnet.ibm.com,
sv@linux.ibm.com
Subject: [PATCH v2 04/16] powerpc: Curb objtool unannotated intra-function warnings
Date: Mon, 29 Aug 2022 11:22:11 +0530 [thread overview]
Message-ID: <20220829055223.24767-5-sv@linux.ibm.com> (raw)
In-Reply-To: <20220829055223.24767-1-sv@linux.ibm.com>
objtool throws the following unannotated intra-function call
warnings:
arch/powerpc/kernel/entry_64.o: warning: objtool: .text+0x4: unannotated intra-function call
arch/powerpc/kvm/book3s_hv_rmhandlers.o: warning: objtool: .text+0xe64: unannotated intra-function call
arch/powerpc/kvm/book3s_hv_rmhandlers.o: warning: objtool: .text+0xee4: unannotated intra-function call
Fix these warnings by annotating intra-function
call, using ANNOTATE_INTRA_FUNCTION_CALL macro,
to indicate that the branch targets are valid.
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
arch/powerpc/kernel/entry_64.S | 2 ++
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 3 +++
2 files changed, 5 insertions(+)
diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
index 01ace4c56104..fb444bc64f3f 100644
--- a/arch/powerpc/kernel/entry_64.S
+++ b/arch/powerpc/kernel/entry_64.S
@@ -14,6 +14,7 @@
* code, and exception/interrupt return code for PowerPC.
*/
+#include <linux/objtool.h>
#include <linux/errno.h>
#include <linux/err.h>
#include <asm/cache.h>
@@ -73,6 +74,7 @@ flush_branch_caches:
// Flush the link stack
.rept 64
+ ANNOTATE_INTRA_FUNCTION_CALL
bl .+4
.endr
b 1f
diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
index de91118df0c5..ea39a0cf591a 100644
--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
@@ -30,6 +30,7 @@
#include <asm/feature-fixups.h>
#include <asm/cpuidle.h>
#include <linux/linkage.h>
+#include <linux/objtool.h>
/* Values in HSTATE_NAPPING(r13) */
#define NAPPING_CEDE 1
@@ -1523,12 +1524,14 @@ kvm_flush_link_stack:
/* Flush the link stack. On Power8 it's up to 32 entries in size. */
.rept 32
+ ANNOTATE_INTRA_FUNCTION_CALL
bl .+4
.endr
/* And on Power9 it's up to 64. */
BEGIN_FTR_SECTION
.rept 32
+ ANNOTATE_INTRA_FUNCTION_CALL
bl .+4
.endr
END_FTR_SECTION_IFSET(CPU_FTR_ARCH_300)
--
2.31.1
next prev parent reply other threads:[~2022-08-29 5:53 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 5:52 [PATCH v2 00/16] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy
2022-08-29 5:52 ` [PATCH v2 01/16] powerpc: Replace unreachable() with it's builtin variant in __WARN_FLAGS() Sathvika Vasireddy
2022-08-30 6:15 ` Christophe Leroy
2022-09-05 10:18 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 02/16] powerpc: override __ALIGN() and __ALIGN_STR() macros Sathvika Vasireddy
2022-08-29 13:26 ` Christophe Leroy
2022-08-29 14:39 ` Sathvika Vasireddy
2022-08-31 3:24 ` Nicholas Piggin
2022-08-31 7:22 ` Michael Ellerman
2022-09-05 11:03 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 03/16] powerpc: Fix objtool unannotated intra-function call warnings Sathvika Vasireddy
2022-08-30 6:16 ` Christophe Leroy
2022-08-30 12:42 ` Christophe Leroy
2022-09-05 11:02 ` Peter Zijlstra
2022-08-29 5:52 ` Sathvika Vasireddy [this message]
2022-08-30 6:26 ` [PATCH v2 04/16] powerpc: Curb objtool unannotated intra-function warnings Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o Sathvika Vasireddy
2022-08-30 6:26 ` Christophe Leroy
2022-09-01 19:17 ` Peter Zijlstra
2022-09-05 10:47 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 06/16] powerpc: Fix objtool unannotated intra-function call warnings on PPC32 Sathvika Vasireddy
2022-08-29 5:52 ` [PATCH v2 07/16] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy
2022-08-30 6:27 ` Christophe Leroy
2022-09-01 19:19 ` Peter Zijlstra
2022-09-02 7:40 ` Michael Ellerman
2022-08-29 5:52 ` [PATCH v2 08/16] objtool: Fix SEGFAULT Sathvika Vasireddy
2022-09-01 19:20 ` Peter Zijlstra
2022-09-02 8:06 ` Christophe Leroy
2022-09-02 8:42 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 09/16] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy
2022-09-01 19:22 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 10/16] objtool: Use target file class size " Sathvika Vasireddy
2022-09-01 19:23 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 11/16] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy
2022-08-30 6:28 ` Christophe Leroy
2022-09-01 19:25 ` Peter Zijlstra
2022-09-05 10:55 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 12/16] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy
2022-08-30 6:31 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 13/16] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy
2022-08-30 6:33 ` Christophe Leroy
2022-09-01 19:28 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy
2022-08-30 6:36 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy
2022-08-30 6:41 ` Christophe Leroy
2022-09-05 10:37 ` Naveen N. Rao
2023-02-04 8:19 ` Randy Dunlap
2023-02-04 8:21 ` Randy Dunlap
2023-02-04 8:30 ` Randy Dunlap
2023-02-04 11:55 ` Christophe Leroy
2023-02-04 13:10 ` Christophe Leroy
2023-02-04 15:47 ` Josh Poimboeuf
2022-09-01 9:32 ` Christophe Leroy
2022-09-01 15:11 ` Segher Boessenkool
2022-09-01 16:38 ` Christophe Leroy
2022-09-01 19:01 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy
2022-08-30 6:44 ` Christophe Leroy
2022-08-31 12:50 ` Christophe Leroy
2022-08-31 17:51 ` Segher Boessenkool
2022-09-05 10:45 ` Naveen N. Rao
2022-09-05 20:43 ` Segher Boessenkool
2022-09-06 6:22 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829055223.24767-5-sv@linux.ibm.com \
--to=sv@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=chenzhongjin@huawei.com \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).