From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D2EECAAA2 for ; Sun, 28 Aug 2022 22:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229492AbiH1WFl (ORCPT ); Sun, 28 Aug 2022 18:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiH1WFk (ORCPT ); Sun, 28 Aug 2022 18:05:40 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C13C72AC75 for ; Sun, 28 Aug 2022 15:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661724337; x=1693260337; h=date:from:to:cc:subject:message-id:mime-version; bh=1ZkxE/mKUfgqZm1KeitF7vCfrKDVS05k1wSy9B0aNDY=; b=Zxqvs+asr1iJq6q7KcXEAEnoQ8BRiXzNWPGgDjnOHljkwXDUktJV6RC5 y/MtBVtcgZajcbuy/HNVDkiazf17klwm05ZZEkJ2+cUgt5LzxXtQlnrg7 YRpsyboJ0fW9D8rpso1ICTWk3glff6b5QJf+YBmGIcoywlF7mho6o9lQ/ Oudy3xHHD8pRYUvW7QYfNkIe+NQx5Rv37uSUkm5fWQta/SriOspuhZtxn 8u4ppmKAz+vBzMDmldlRm2VtB+CrdXl08hwIjdbkh4sYPwEXs/b2g0Ito XJjyIqI9jeF1FJRNlT+0dY8NoMWR5G40Knb1PjNfAZMgf6nETXVW5w4Mz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10453"; a="294779984" X-IronPort-AV: E=Sophos;i="5.93,271,1654585200"; d="scan'208";a="294779984" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2022 15:05:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,271,1654585200"; d="scan'208";a="562010522" Received: from lkp-server01.sh.intel.com (HELO fc16deae1c42) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 28 Aug 2022 15:05:35 -0700 Received: from kbuild by fc16deae1c42 with local (Exim 4.96) (envelope-from ) id 1oSQPO-0001f2-2X; Sun, 28 Aug 2022 22:05:34 +0000 Date: Mon, 29 Aug 2022 06:05:21 +0800 From: kernel test robot To: Ilya Leoshkevich Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Heiko Carstens Subject: drivers/message/fusion/mptctl.c:1494:9: warning: 'strncpy' specified bound 12 equals destination size Message-ID: <202208290627.EFFCtUl5-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ilya, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8379c0b31fbc5d20946f617f8e2fe4791e6f58c1 commit: e37b3dd063a1a68e28a7cfaf77c84c472112e330 s390: enable KCSAN date: 1 year, 1 month ago config: s390-randconfig-r004-20220829 (https://download.01.org/0day-ci/archive/20220829/202208290627.EFFCtUl5-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e37b3dd063a1a68e28a7cfaf77c84c472112e330 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout e37b3dd063a1a68e28a7cfaf77c84c472112e330 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/message/fusion/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/message/fusion/mptctl.c: In function 'mptctl_hp_hostinfo': drivers/message/fusion/mptctl.c:2329:33: warning: variable 'retval' set but not used [-Wunused-but-set-variable] 2329 | int retval; | ^~~~~~ In function 'mptctl_readtest', inlined from '__mptctl_ioctl.isra' at drivers/message/fusion/mptctl.c:661:10: >> drivers/message/fusion/mptctl.c:1494:9: warning: 'strncpy' specified bound 12 equals destination size [-Wstringop-truncation] 1494 | strncpy (karg.product, ioc->prod_name, MPT_PRODUCT_LENGTH); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/strncpy +1494 drivers/message/fusion/mptctl.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 1459 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1460 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ ^1da177e4c3f41 Linus Torvalds 2005-04-16 1461 /* MPT IOCTL Test function. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1462 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 1463 * Outputs: None. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1464 * Return: 0 if successful ^1da177e4c3f41 Linus Torvalds 2005-04-16 1465 * -EFAULT if data unavailable ^1da177e4c3f41 Linus Torvalds 2005-04-16 1466 * -ENODEV if no such device/adapter ^1da177e4c3f41 Linus Torvalds 2005-04-16 1467 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 1468 static int 28d76df18f0ad5 Dan Carpenter 2020-01-14 1469 mptctl_readtest (MPT_ADAPTER *ioc, unsigned long arg) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1470 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1471 struct mpt_ioctl_test __user *uarg = (void __user *) arg; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1472 struct mpt_ioctl_test karg; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1473 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1474 if (copy_from_user(&karg, uarg, sizeof(struct mpt_ioctl_test))) { 29dd3609f2fc70 Eric Moore 2007-09-14 1475 printk(KERN_ERR MYNAM "%s@%d::mptctl_readtest - " ^1da177e4c3f41 Linus Torvalds 2005-04-16 1476 "Unable to read in mpt_ioctl_test struct @ %p\n", ^1da177e4c3f41 Linus Torvalds 2005-04-16 1477 __FILE__, __LINE__, uarg); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1478 return -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1479 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1480 09120a8cd38dbd Prakash, Sathya 2007-07-24 1481 dctlprintk(ioc, printk(MYIOC_s_DEBUG_FMT "mptctl_readtest called.\n", 09120a8cd38dbd Prakash, Sathya 2007-07-24 1482 ioc->name)); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1483 /* Fill in the data and return the structure to the calling ^1da177e4c3f41 Linus Torvalds 2005-04-16 1484 * program ^1da177e4c3f41 Linus Torvalds 2005-04-16 1485 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 1486 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1487 #ifdef MFCNT ^1da177e4c3f41 Linus Torvalds 2005-04-16 1488 karg.chip_type = ioc->mfcnt; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1489 #else ^1da177e4c3f41 Linus Torvalds 2005-04-16 1490 karg.chip_type = ioc->pcidev->device; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1491 #endif ^1da177e4c3f41 Linus Torvalds 2005-04-16 1492 strncpy (karg.name, ioc->name, MPT_MAX_NAME); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1493 karg.name[MPT_MAX_NAME-1]='\0'; ^1da177e4c3f41 Linus Torvalds 2005-04-16 @1494 strncpy (karg.product, ioc->prod_name, MPT_PRODUCT_LENGTH); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1495 karg.product[MPT_PRODUCT_LENGTH-1]='\0'; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1496 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1497 /* Copy the data from kernel memory to user memory ^1da177e4c3f41 Linus Torvalds 2005-04-16 1498 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 1499 if (copy_to_user((char __user *)arg, &karg, sizeof(struct mpt_ioctl_test))) { 29dd3609f2fc70 Eric Moore 2007-09-14 1500 printk(MYIOC_s_ERR_FMT "%s@%d::mptctl_readtest - " ^1da177e4c3f41 Linus Torvalds 2005-04-16 1501 "Unable to write out mpt_ioctl_test struct @ %p\n", 29dd3609f2fc70 Eric Moore 2007-09-14 1502 ioc->name, __FILE__, __LINE__, uarg); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1503 return -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1504 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1505 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1506 return 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1507 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1508 :::::: The code at line 1494 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds :::::: CC: Linus Torvalds -- 0-DAY CI Kernel Test Service https://01.org/lkp