From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19AEECAAD4 for ; Mon, 29 Aug 2022 19:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbiH2T0H (ORCPT ); Mon, 29 Aug 2022 15:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbiH2T0F (ORCPT ); Mon, 29 Aug 2022 15:26:05 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC3448A7C6 for ; Mon, 29 Aug 2022 12:26:02 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id l3so8942604plb.10 for ; Mon, 29 Aug 2022 12:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=VhWA9zltNIvjVh8Z8DuaAQPbsy5x2B8HO8rAH51nZcs=; b=eJWdBVSqu/L3b4Gx52Gb4jKAo92U2TKDhf7bztvP63HYkGxkmA2CVM9dFnWwHtbxyi /oqM5qROQsahReI/SrXkrJbmthPE66kBHogzexruiDDXvtE1a30nJPJFmAlle+/lnR0z /2BBq6o/dTJ7AVRL7iOu8FeE1wwhMaUGWML4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=VhWA9zltNIvjVh8Z8DuaAQPbsy5x2B8HO8rAH51nZcs=; b=Tzm47BJnfUXj9ZuhE1GKIgl/mM+h62CfbOt9wsC6z7ChzoBd6YWTGEmJns2cylWvay LZXOyTM4er6rn8h8I5oUPVZ8ifnYtIJe5somMiE6IYYk02ye7TS3uVTGYo5FCXfHVEg2 cxE8jKwrZfd2X1B6ccySX0vx2+P83VdYCrmaB0z4DPv/HgPH/+iEZFZI+/kzExeD5yxL FM7vlaxcAH/+AkkDiA9t7HV5sxeytdlpiF6BxnmKrvkX7U3W8Ig6Iw0UaPJSBklC/6Fp qfUExik9pWfbEHB3+N7519pkZmCuB4WSjWhH0X9l/fpUEaHEV3LsVBVbuLWKhJMVfzUU eQbw== X-Gm-Message-State: ACgBeo2IECUbENUkZ3knwUmGoDi2FtObYW+TxJaUZLi7WXKTjE7A5t3i 0q10Q9rBBHbUKly7mnlDW9HjVA== X-Google-Smtp-Source: AA6agR7u3y84UCyhfAk1IOVCe6FUtEm4rdvgw806xCycjSX/X3gzP52Q1hWrrhqe4GxNhc/peNJs5A== X-Received: by 2002:a17:902:7003:b0:172:cbb0:9af8 with SMTP id y3-20020a170902700300b00172cbb09af8mr18161965plk.57.1661801161717; Mon, 29 Aug 2022 12:26:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t17-20020a170902e85100b00172e6c66f84sm7901946plg.148.2022.08.29.12.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 12:26:00 -0700 (PDT) Date: Mon, 29 Aug 2022 12:25:59 -0700 From: Kees Cook To: Robert Elliott Cc: mpe@ellerman.id.au, nanya@linux.vnet.ibm.com, asahiroy@kernel.org, michal.lkml@markovi.net, corbet@lwn.net, ndesaulniers@google.com, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] docs/core-api: expand Fedora instructions for GCC plugins Message-ID: <202208291225.A0D3FAFC@keescook> References: <20220827193836.2582079-1-elliott@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220827193836.2582079-1-elliott@hpe.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 27, 2022 at 02:38:36PM -0500, Robert Elliott wrote: > In Fedora 36, cross-compiling an allmodconfig configuration > for other architectures on x86 fails with this problem: > > In file included from ../scripts/gcc-plugins/gcc-common.h:95, > from ../scripts/gcc-plugins/latent_entropy_plugin.c:78: > /usr/lib/gcc/aarch64-linux-gnu/12/plugin/include/builtins.h:23:10: fatal > error: mpc.h: No such file or directory > 23 | #include > | ^~~~~~~ > compilation terminated. > > In that distro, that header file is available in the separate > libmpc-devel package. > > Although future versions of Fedora might correctly mark > that dependency, mention this additional package. > > To help detect such problems ahead of time, describe the > gcc -print-file-name=plugin > command that is used by scripts/gcc-plugins/Kconfig to detect > plugins [1]. > > [1] https://lore.kernel.org/lkml/CAHk-=wjjiYjCp61gdAMpDOsUBU-A2hFFKJoVx5VAC7yV4K6WYg@xxxxxxxxxxxxxx/ > > Fixes: 43e96ef8b70c50f ("docs/core-api: Add Fedora instructions for GCC plugins"); > Signed-off-by: Robert Elliott Thanks! Reviewed-by: Kees Cook Jon, do you want to take this since it's entirely in the .rst file? -- Kees Cook