From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4EFFECAAD4 for ; Mon, 29 Aug 2022 12:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229504AbiH2MvJ (ORCPT ); Mon, 29 Aug 2022 08:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbiH2Mus (ORCPT ); Mon, 29 Aug 2022 08:50:48 -0400 Received: from outbound-smtp22.blacknight.com (outbound-smtp22.blacknight.com [81.17.249.190]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD83A15A12 for ; Mon, 29 Aug 2022 05:37:27 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp22.blacknight.com (Postfix) with ESMTPS id D6847BAC22 for ; Mon, 29 Aug 2022 13:37:25 +0100 (IST) Received: (qmail 4968 invoked from network); 29 Aug 2022 12:37:25 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2022 12:37:25 -0000 Date: Mon, 29 Aug 2022 13:37:21 +0100 From: Mel Gorman To: Abel Wu Cc: Peter Zijlstra , Mel Gorman , Vincent Guittot , Josh Don , Chen Yu , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] sched/fair: remove useless check in select_idle_core Message-ID: <20220829123721.5xnqfrpcbdafwmcd@techsingularity.net> References: <20220712082036.5130-1-wuyun.abel@bytedance.com> <20220712082036.5130-6-wuyun.abel@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20220712082036.5130-6-wuyun.abel@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2022 at 04:20:36PM +0800, Abel Wu wrote: > The function only gets called when sds->has_idle_cores is true > which can be possible only when sched_smt_present is enabled. > This change also aligns select_idle_core with select_idle_smt > that the caller do the check if necessary. > > Signed-off-by: Abel Wu Acked-by: Mel Gorman -- Mel Gorman SUSE Labs