* [PATCH] MIPS: loongson32: ls1c: Fix hang during startup
@ 2022-08-23 11:17 Keguang Zhang
2022-08-29 13:14 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Keguang Zhang @ 2022-08-23 11:17 UTC (permalink / raw)
To: linux-mips, linux-kernel; +Cc: Thomas Bogendoerfer, Yang Ling, Keguang Zhang
From: Yang Ling <gnaygnil@gmail.com>
The RTCCTRL reg of LS1C is obselete.
Writing this reg will cause system hang.
Fixes: 60219c563c9b6 ("MIPS: Add RTC support for Loongson1C board")
Signed-off-by: Yang Ling <gnaygnil@gmail.com>
Tested-by: Keguang Zhang <keguang.zhang@gmail.com>
Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
---
arch/mips/loongson32/ls1c/board.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/loongson32/ls1c/board.c b/arch/mips/loongson32/ls1c/board.c
index e9de6da0ce51..9dcfe9de55b0 100644
--- a/arch/mips/loongson32/ls1c/board.c
+++ b/arch/mips/loongson32/ls1c/board.c
@@ -15,7 +15,6 @@ static struct platform_device *ls1c_platform_devices[] __initdata = {
static int __init ls1c_platform_init(void)
{
ls1x_serial_set_uartclk(&ls1x_uart_pdev);
- ls1x_rtc_set_extclk(&ls1x_rtc_pdev);
return platform_add_devices(ls1c_platform_devices,
ARRAY_SIZE(ls1c_platform_devices));
base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] MIPS: loongson32: ls1c: Fix hang during startup
2022-08-23 11:17 [PATCH] MIPS: loongson32: ls1c: Fix hang during startup Keguang Zhang
@ 2022-08-29 13:14 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2022-08-29 13:14 UTC (permalink / raw)
To: Keguang Zhang; +Cc: linux-mips, linux-kernel, Yang Ling
On Tue, Aug 23, 2022 at 07:17:25PM +0800, Keguang Zhang wrote:
> From: Yang Ling <gnaygnil@gmail.com>
>
> The RTCCTRL reg of LS1C is obselete.
> Writing this reg will cause system hang.
>
> Fixes: 60219c563c9b6 ("MIPS: Add RTC support for Loongson1C board")
> Signed-off-by: Yang Ling <gnaygnil@gmail.com>
> Tested-by: Keguang Zhang <keguang.zhang@gmail.com>
> Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> arch/mips/loongson32/ls1c/board.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/loongson32/ls1c/board.c b/arch/mips/loongson32/ls1c/board.c
> index e9de6da0ce51..9dcfe9de55b0 100644
> --- a/arch/mips/loongson32/ls1c/board.c
> +++ b/arch/mips/loongson32/ls1c/board.c
> @@ -15,7 +15,6 @@ static struct platform_device *ls1c_platform_devices[] __initdata = {
> static int __init ls1c_platform_init(void)
> {
> ls1x_serial_set_uartclk(&ls1x_uart_pdev);
> - ls1x_rtc_set_extclk(&ls1x_rtc_pdev);
>
> return platform_add_devices(ls1c_platform_devices,
> ARRAY_SIZE(ls1c_platform_devices));
>
> base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> --
> 2.34.1
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-29 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-23 11:17 [PATCH] MIPS: loongson32: ls1c: Fix hang during startup Keguang Zhang
2022-08-29 13:14 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox