From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40FDBECAAD1 for ; Tue, 30 Aug 2022 05:06:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbiH3FGM (ORCPT ); Tue, 30 Aug 2022 01:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiH3FGK (ORCPT ); Tue, 30 Aug 2022 01:06:10 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 160D26172C for ; Mon, 29 Aug 2022 22:06:04 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id B25A868AA6; Tue, 30 Aug 2022 07:05:59 +0200 (CEST) Date: Tue, 30 Aug 2022 07:05:59 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH -next v4 1/6] Revert "frontswap: remove support for multiple ops" Message-ID: <20220830050559.GA23877@lst.de> References: <20220829132302.3367054-1-liushixin2@huawei.com> <20220829132302.3367054-2-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829132302.3367054-2-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022 at 09:22:57PM +0800, Liu Shixin wrote: > This reverts commit 1da0d94a3ec8c5f3793b7be8538b55e60ebeefe3. Err, no, this is a way to big hammer and going in the wrong way. If we can't have a sane way to fix it, the fix is just to remove the now rather pointless fontswap abstraction entirely. I'm on vacation this week, but I'll look into it ASAP once back.