From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C5EECAAA1 for ; Tue, 30 Aug 2022 17:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231332AbiH3Rc7 (ORCPT ); Tue, 30 Aug 2022 13:32:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231961AbiH3Rb6 (ORCPT ); Tue, 30 Aug 2022 13:31:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBCF715A206; Tue, 30 Aug 2022 10:28:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C63D9B81D1B; Tue, 30 Aug 2022 17:26:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7087C433D6; Tue, 30 Aug 2022 17:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661880403; bh=CalIawEmvBT6oJKZ5FkEZ4qq1hGCQEB6V9ztbQ59/Gk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EngCaCnWKQa/P6s6cadzt7uqb9mtoBeM+C3oNLrt1ouqqeDH5RoigWAz1v2wEzS5o xlhrFiSY76qvoXUai31DHQXMNVFUaOtG9JIpJWcgKamTMbr3YMTG8KcdOktre3OdwA Q0/CjtwiMoX1voPjBX/daTOdeHd/Nv76lk1apnlkSecCPS7USGMd7DrZr/E8A0RVUP KzgWj0FM4Ut9LW+HhbPlnWtEbfEa8x5RKzanyyUAean5Y9DPIWWXntFdglT8H1m9t3 wDRQX7z2/vDY/I1dpSjZTaBrBaERpZo1kQTq4qQRHtgnXYtGWt7AeJ8C6QYfrxLsxS vzNu4oxRTVHfA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Li Qiong , Helge Deller , Sasha Levin , James.Bottomley@HansenPartnership.com, linux-parisc@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 4/8] parisc: ccio-dma: Handle kmalloc failure in ccio_init_resources() Date: Tue, 30 Aug 2022 13:26:27 -0400 Message-Id: <20220830172631.581969-4-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220830172631.581969-1-sashal@kernel.org> References: <20220830172631.581969-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Qiong [ Upstream commit d46c742f827fa2326ab1f4faa1cccadb56912341 ] As the possible failure of the kmalloc(), it should be better to fix this error path, check and return '-ENOMEM' error code. Signed-off-by: Li Qiong Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/parisc/ccio-dma.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c index 224a364097672..cc23b30337c16 100644 --- a/drivers/parisc/ccio-dma.c +++ b/drivers/parisc/ccio-dma.c @@ -1416,15 +1416,17 @@ ccio_init_resource(struct resource *res, char *name, void __iomem *ioaddr) } } -static void __init ccio_init_resources(struct ioc *ioc) +static int __init ccio_init_resources(struct ioc *ioc) { struct resource *res = ioc->mmio_region; char *name = kmalloc(14, GFP_KERNEL); - + if (unlikely(!name)) + return -ENOMEM; snprintf(name, 14, "GSC Bus [%d/]", ioc->hw_path); ccio_init_resource(res, name, &ioc->ioc_regs->io_io_low); ccio_init_resource(res + 1, name, &ioc->ioc_regs->io_io_low_hv); + return 0; } static int new_ioc_area(struct resource *res, unsigned long size, @@ -1578,7 +1580,10 @@ static int __init ccio_probe(struct parisc_device *dev) return -ENOMEM; } ccio_ioc_init(ioc); - ccio_init_resources(ioc); + if (ccio_init_resources(ioc)) { + kfree(ioc); + return -ENOMEM; + } hppa_dma_ops = &ccio_ops; dev->dev.platform_data = kzalloc(sizeof(struct pci_hba_data), GFP_KERNEL); -- 2.35.1