* [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()
@ 2022-08-30 17:27 Andy Shevchenko
2022-08-31 17:01 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-08-30 17:27 UTC (permalink / raw)
To: Keith Busch, linux-arch, linux-kernel
Cc: Arnd Bergmann, Andrew Morton, Andy Shevchenko
There is a convention to use internal kernel types, hence replace
__u8 by u8.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Cc'ed to Andrew since original code authors didn't respond for a month
include/asm-generic/unaligned.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/unaligned.h b/include/asm-generic/unaligned.h
index df30f11b4a46..699650f81970 100644
--- a/include/asm-generic/unaligned.h
+++ b/include/asm-generic/unaligned.h
@@ -126,7 +126,7 @@ static inline void put_unaligned_le24(const u32 val, void *p)
__put_unaligned_le24(val, p);
}
-static inline void __put_unaligned_be48(const u64 val, __u8 *p)
+static inline void __put_unaligned_be48(const u64 val, u8 *p)
{
*p++ = val >> 40;
*p++ = val >> 32;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()
2022-08-30 17:27 [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48() Andy Shevchenko
@ 2022-08-31 17:01 ` Keith Busch
2022-09-01 20:14 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Keith Busch @ 2022-08-31 17:01 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-arch, linux-kernel, Arnd Bergmann, Andrew Morton
On Tue, Aug 30, 2022 at 08:27:13PM +0300, Andy Shevchenko wrote:
> There is a convention to use internal kernel types, hence replace
> __u8 by u8.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sorry for the delay, looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()
2022-08-31 17:01 ` Keith Busch
@ 2022-09-01 20:14 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-09-01 20:14 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-arch, linux-kernel, Arnd Bergmann, Andrew Morton
On Wed, Aug 31, 2022 at 11:01:11AM -0600, Keith Busch wrote:
> On Tue, Aug 30, 2022 at 08:27:13PM +0300, Andy Shevchenko wrote:
> > There is a convention to use internal kernel types, hence replace
> > __u8 by u8.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Sorry for the delay, looks good.
>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
Thanks!
Andrew, can you pick this up?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-01 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-30 17:27 [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48() Andy Shevchenko
2022-08-31 17:01 ` Keith Busch
2022-09-01 20:14 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox