From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06ABEECAAD4 for ; Tue, 30 Aug 2022 21:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbiH3Vcq (ORCPT ); Tue, 30 Aug 2022 17:32:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiH3Vcl (ORCPT ); Tue, 30 Aug 2022 17:32:41 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B9D189CCC; Tue, 30 Aug 2022 14:32:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B808421D95; Tue, 30 Aug 2022 21:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1661895158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d3perT1+wYBFzimt6PoAuQXJOi1UiBFbwqJ4dPzW82w=; b=Ui5uyccbAyMenyeCJNV9CZh8INAK2XGYUdZXbl1x9FVimqaE44fHUM7skTfanB3I+UKk9Z OEbOrnvAM9K5ufTyvpy17Eix+jxjJP6JRCV0ltnSU34bZJ9gnV60kUt415OX0TS2THithE P/EgovYEzUe+XcN0QvU4dIz7Gj6u77I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1661895158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d3perT1+wYBFzimt6PoAuQXJOi1UiBFbwqJ4dPzW82w=; b=1x1EhlhLnklmr9OfhRAa5rCd3w5b8/oP4g6kapHLbvHODvivdzeuRwixuJ+sndIHfyFELz Kd79p5xo+ubGd1BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8305C13ACF; Tue, 30 Aug 2022 21:32:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eWJjHvaBDmMUWgAAMHmgww (envelope-from ); Tue, 30 Aug 2022 21:32:38 +0000 Date: Tue, 30 Aug 2022 23:32:37 +0200 From: Jean Delvare To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH AUTOSEL 5.19 01/33] firmware: dmi: Use the proper accessor for the version field Message-ID: <20220830233237.0c08cc7e@endymion.delvare> In-Reply-To: <20220830171825.580603-1-sashal@kernel.org> References: <20220830171825.580603-1-sashal@kernel.org> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sasha, On Tue, 30 Aug 2022 13:17:52 -0400, Sasha Levin wrote: > From: Andy Shevchenko > > [ Upstream commit d2139dfca361a1f5bfc4d4a23455b1a409a69cd4 ] > > The byte at offset 6 represents length. Don't take it and drop it > immediately by using proper accessor, i.e. get_unaligned_be24(). > > [JD: Change the subject to something less frightening] Nack. This is NOT a bug fix, there's simply no reason to backport this to stable kernel trees. Thanks, -- Jean Delvare SUSE L3 Support