Re: [PATCH] audit: remove obvious unnecessary header files

chi wu
2022-08-31T01:04:26Z

Paul Moore <paul@paul-moore.com> 于2022年8月31日周三 08:49写道：
>
> On Tue, Aug 30, 2022 at 8:20 PM chi wu <wuchi.zero@gmail.com> wrote:
> > Paul Moore <paul@paul-moore.com> 于2022年8月31日周三 01:04写道：
> > >
> > >
> > > Hi Wuchi, can you explain what process you used to determine that
> > > these header file includes were unnecessary?
> >
> > When reading the code, if I don't found the user of the *.h in the *.c
> > file,I will think that is unnecessary. For example, #include
> > <linux/kthread.h> in the audit.c, I don't found the use of kthread* in
> > the file.
> > But, I just build that without "W=1 " , the after test robot show that I
> > was wrong. and I don't sure that if it is true to remove some header
> > files.
>
> Yes, I would recommend that you focus your time and energy on other
> tasks within the Linux Kernel. I'm very happy to see patches which
> improve the audit subsystem, but I don't believe verifying the header
> file usage is a good use of time at this point.
>
thanks very much

> --
> paul-moore.com