From: <zhangxuezhi3@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
zhangxuezhi1@coolpad.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit
Date: Thu, 1 Sep 2022 09:05:08 +0800 [thread overview]
Message-ID: <20220901090508.4f3a6903@carlis-virtual-machine> (raw)
In-Reply-To: <Yw9p47naEjsCWAJW@kroah.com>
On Wed, 31 Aug 2022 16:02:11 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Aug 31, 2022 at 08:55:20PM +0800, Xuezhi Zhang wrote:
> > From: zhangxuezhi1 <zhangxuezhi1@coolpad.com>
> >
> > Fix up all sysfs show entries to use sysfs_emit
>
> This says "what", but not "why".
>
> Please read the kernel documentation for how to write a good changelog
> text.
>
> >
> > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> > ---
> > v2: use a proper name for the Signed-off-by line.
>
> Does not match the From: line :(
>
>
> thanks,
>
> greg k-h
OK, I see.
Thanks.
prev parent reply other threads:[~2022-09-01 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 12:55 [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit Xuezhi Zhang
2022-08-31 12:58 ` Ian Abbott
2022-08-31 14:02 ` Greg KH
2022-09-01 1:05 ` zhangxuezhi3 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901090508.4f3a6903@carlis-virtual-machine \
--to=zhangxuezhi3@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangxuezhi1@coolpad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox