From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: tiwai@suse.com, perex@perex.cz,
amadeuszx.slawinski@linux.intel.com,
pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com,
lgirdwood@gmail.com, kai.vehmanen@linux.intel.com,
peter.ujfalusi@linux.intel.com,
ranjani.sridharan@linux.intel.com,
yung-chuan.liao@linux.intel.com, willy@infradead.org,
linux-kernel@vger.kernel.org, andy@kernel.org,
intel-poland@eclists.intel.com, andy.shevchenko@gmail.com,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH v5 0/2] lib/string_helpers: Introduce parse_int_array_user()
Date: Fri, 2 Sep 2022 15:32:54 +0200 [thread overview]
Message-ID: <20220902133256.789165-1-cezary.rojewski@intel.com> (raw)
Continuation of recent upstream discussion [1] regarding user string
tokenization.
First, parse_int_array_user() is introduced to allow for splitting
specified user string into a sequence of integers. Makes use of
get_options() internally so the parsing logic is not duplicated.
With that done, redundant parts of the sound driver are removed.
Originally similar functionality was added for the SOF sound driver. As
more users are on the horizon, it is desirable to update existing
string_helpers code and provide a unified solution.
Changes in v5:
- fixed kernel doc for parse_int_array_user()
Changes in v4:
- renamed the function to parse_int_array_user()
- at the name several local variable names have been reworded to match
the above
Changes in v3:
- relocated tokenize_user_input() implementation to string_helpers as
requested by Matthew
Changes in v2:
- reused get_options() so no parsing logic is duplicated
- simplified __user variant with help of memdup_user_nul()
Both suggested by Andy, thanks for thorough review
[1]: https://lore.kernel.org/alsa-devel/20220707091301.1282291-1-cezary.rojewski@intel.com/
Cezary Rojewski (2):
lib/string_helpers: Introduce parse_int_array_user()
ASoC: SOF: Remove strsplit_u32() and tokenize_input()
include/linux/string_helpers.h | 2 +
lib/string_helpers.c | 44 +++++++++++++
sound/soc/sof/sof-client-probes.c | 104 ++++++------------------------
3 files changed, 64 insertions(+), 86 deletions(-)
--
2.25.1
next reply other threads:[~2022-09-02 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 13:32 Cezary Rojewski [this message]
2022-09-02 13:32 ` [PATCH v5 1/2] lib/string_helpers: Introduce parse_int_array_user() Cezary Rojewski
2022-09-02 13:32 ` [PATCH v5 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize_input() Cezary Rojewski
2022-09-02 14:25 ` Andy Shevchenko
2022-09-04 10:09 ` Cezary Rojewski
2022-09-02 14:16 ` [PATCH v5 0/2] lib/string_helpers: Introduce parse_int_array_user() Andy Shevchenko
2022-09-04 10:21 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902133256.789165-1-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=intel-poland@eclists.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=willy@infradead.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox