[PATCH v1 10/17] pinctrl: cy8c95x0: Remove custom ->set_config()

Andy Shevchenko
2022-09-02T18:34:05Z

Since we have pin configuration getter and setter provided,
there is no need to duplicate that in the custom ->set_config().
Instead, switch to gpiochip_generic_config().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-cy8c95x0.c | 26 +-------------------------
1 file changed, 1 insertion(+), 25 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c
index 97da22016cce..55bd48c9d020 100644
--- a/drivers/pinctrl/pinctrl-cy8c95x0.c
+++ b/drivers/pinctrl/pinctrl-cy8c95x0.c
@@ -761,30 +761,6 @@ static int cy8c95x0_gpio_set_pincfg(struct cy8c95x0_pinctrl *chip,
return ret;
}

-static int cy8c95x0_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
- unsigned long config)
-{
- struct cy8c95x0_pinctrl *chip = gpiochip_get_data(gc);
- unsigned long arg = pinconf_to_config_argument(config);
-
- switch (pinconf_to_config_param(config)) {
- case PIN_CONFIG_INPUT_ENABLE:
- return cy8c95x0_gpio_direction_input(gc, offset);
- case PIN_CONFIG_OUTPUT:
- return cy8c95x0_gpio_direction_output(gc, offset, arg);
- case PIN_CONFIG_MODE_PWM:
- case PIN_CONFIG_BIAS_PULL_UP:
- case PIN_CONFIG_BIAS_PULL_DOWN:
- case PIN_CONFIG_BIAS_DISABLE:
- case PIN_CONFIG_DRIVE_OPEN_DRAIN:
- case PIN_CONFIG_DRIVE_OPEN_SOURCE:
- case PIN_CONFIG_DRIVE_PUSH_PULL:
- return cy8c95x0_gpio_set_pincfg(chip, offset, config);
- default:
- return -ENOTSUPP;
- }
-}
-
static int cy8c95x0_gpio_get_multiple(struct gpio_chip *gc,
unsigned long *mask, unsigned long *bits)
{
@@ -825,7 +801,7 @@ static int cy8c95x0_setup_gpiochip(struct cy8c95x0_pinctrl *chip)
gc->get_direction = cy8c95x0_gpio_get_direction;
gc->get_multiple = cy8c95x0_gpio_get_multiple;
gc->set_multiple = cy8c95x0_gpio_set_multiple;
- gc->set_config = cy8c95x0_gpio_set_config;
+ gc->set_config = gpiochip_generic_config,
gc->can_sleep = true;
gc->add_pin_ranges = cy8c95x0_add_pin_ranges;

--
2.35.1