Re: [PATCH V2 0/6] riscv: Add GENERIC_ENTRY, IRQ_STACKS support

Guo Ren
2022-09-06T01:55:49Z

On Mon, Sep 5, 2022 at 9:27 PM Jisheng Zhang <jszhang@kernel.org> wrote:
>
> On Sun, Sep 04, 2022 at 03:26:31AM -0400, guoren@kernel.org wrote:
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > The patches convert riscv to use the generic entry infrastructure from
> > kernel/entry/*. Add independent irq stacks (IRQ_STACKS) for percpu to
>
> Amazing! You read my mind. I planed to do similar series this week, as
I'm happy you liked it.

> can be seen, I didn't RESEND the riscv irqstack patch, I planed to add
> irqstack after generic entry. Thanks for this series.
>
> Will read and test your patches soon. A minor comments below.
Thx, any tests and reviews are helpful.

>
> > prevent kernel stack overflows. Add the HAVE_SOFTIRQ_ON_OWN_STACK
> > feature for the IRQ_STACKS config. You can try it directly with [1].
> >
> > [1] https://github.com/guoren83/linux/tree/generic_entry_v2
> >
> > Changes in V2:
> > - Fixup compile error by include "riscv: ptrace: Remove duplicate
> > operation"
> > https://lore.kernel.org/linux-riscv/20220903162328.1952477-2-guoren@kernel.org/T/#u
> > - Fixup compile warning
> > Reported-by: kernel test robot <lkp@intel.com>
> > - Add test repo link in cover letter
> >
> > Guo Ren (6):
> > riscv: ptrace: Remove duplicate operation
> > riscv: convert to generic entry
> > riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK
> > riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK
> > riscv: elf_kexec: Fixup compile warning
> > riscv: compat_syscall_table: Fixup compile warning
>
> It's better to move these two patches ahead of patch2.
Okay.

>
> >
> > arch/riscv/Kconfig | 10 +
> > arch/riscv/include/asm/csr.h | 1 -
> > arch/riscv/include/asm/entry-common.h | 8 +
> > arch/riscv/include/asm/irq.h | 3 +
> > arch/riscv/include/asm/ptrace.h | 10 +-
> > arch/riscv/include/asm/stacktrace.h | 5 +
> > arch/riscv/include/asm/syscall.h | 6 +
> > arch/riscv/include/asm/thread_info.h | 15 +-
> > arch/riscv/include/asm/vmap_stack.h | 28 +++
> > arch/riscv/kernel/Makefile | 1 +
> > arch/riscv/kernel/elf_kexec.c | 4 +
> > arch/riscv/kernel/entry.S | 255 +++++---------------------
> > arch/riscv/kernel/irq.c | 75 ++++++++
> > arch/riscv/kernel/ptrace.c | 41 -----
> > arch/riscv/kernel/signal.c | 21 +--
> > arch/riscv/kernel/sys_riscv.c | 26 +++
> > arch/riscv/kernel/traps.c | 11 ++
> > arch/riscv/mm/fault.c | 12 +-
> > 18 files changed, 250 insertions(+), 282 deletions(-)
> > create mode 100644 arch/riscv/include/asm/entry-common.h
> > create mode 100644 arch/riscv/include/asm/vmap_stack.h
> >
> > --
> > 2.36.1
> >

--
Best Regards
Guo Ren