From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH V2 0/6] perf intel-pt: Support itrace option flag d+e to log on error
Date: Mon, 5 Sep 2022 10:34:18 +0300 [thread overview]
Message-ID: <20220905073424.3971-1-adrian.hunter@intel.com> (raw)
Hi
Here are a few patches to add the ability to output the decoding debug log
only when there are decoding errors.
This is motivated by the fact that a full log can be very large, so just
getting interesting bits is useful for analyzing errors.
If necessary, the size of output on error is configurable via perf config,
and perf_config_scan() was added in the 1st patch to make that simpler.
The 2nd patch adds the new option flag to auxtrace.
There are a couple of very minor and essentially unrelated changes in
patches 3 and 4.
The main Intel PT change is in patch 5 and there is a small example in the
commit message.
Changes in V2:
perf intel-pt: Support itrace option flag d+e to log on error
Ensure log_buf is defined before use
perf intel-pt: Remove first line of log dumped on error
Remove first line only if the buffer has wrapped
Adrian Hunter (6):
perf tools: Add perf_config_scan()
perf auxtrace: Add itrace option flag d+e to log on error
perf intel-pt: Improve man page layout slightly
perf intel-pt: Improve object code read error message
perf intel-pt: Support itrace option flag d+e to log on error
perf intel-pt: Remove first line of log dumped on error
tools/perf/Documentation/itrace.txt | 1 +
tools/perf/Documentation/perf-config.txt | 7 ++
tools/perf/Documentation/perf-intel-pt.txt | 13 ++-
tools/perf/util/auxtrace.c | 13 +++
tools/perf/util/auxtrace.h | 3 +
tools/perf/util/config.c | 31 +++++++
tools/perf/util/config.h | 1 +
tools/perf/util/intel-pt-decoder/intel-pt-log.c | 117 +++++++++++++++++++++++-
tools/perf/util/intel-pt-decoder/intel-pt-log.h | 3 +-
tools/perf/util/intel-pt.c | 23 ++++-
10 files changed, 206 insertions(+), 6 deletions(-)
Regards
Adrian
next reply other threads:[~2022-09-05 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 7:34 Adrian Hunter [this message]
2022-09-05 7:34 ` [PATCH V2 1/6] perf tools: Add perf_config_scan() Adrian Hunter
2022-09-05 7:34 ` [PATCH V2 2/6] perf auxtrace: Add itrace option flag d+e to log on error Adrian Hunter
2022-09-05 7:34 ` [PATCH V2 3/6] perf intel-pt: Improve man page layout slightly Adrian Hunter
2022-09-05 7:34 ` [PATCH V2 4/6] perf intel-pt: Improve object code read error message Adrian Hunter
2022-09-05 7:34 ` [PATCH V2 5/6] perf intel-pt: Support itrace option flag d+e to log on error Adrian Hunter
2022-09-05 7:34 ` [PATCH V2 6/6] perf intel-pt: Remove first line of log dumped " Adrian Hunter
2022-09-06 13:05 ` [PATCH V2 0/6] perf intel-pt: Support itrace option flag d+e to log " Arnaldo Carvalho de Melo
2022-09-06 17:24 ` Namhyung Kim
2022-09-08 19:09 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905073424.3971-1-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox