From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <vkoul@kernel.org>, <yung-chuan.liao@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>, <lgirdwood@gmail.com>,
<peter.ujfalusi@linux.intel.com>,
<ranjani.sridharan@linux.intel.com>,
<kai.vehmanen@linux.intel.com>, <daniel.baluta@nxp.com>,
<sanyog.r.kale@intel.com>, <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>,
<sound-open-firmware@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH 0/7] soundwire: Fix driver removal
Date: Wed, 7 Sep 2022 11:13:55 +0100 [thread overview]
Message-ID: <20220907101402.4685-1-rf@opensource.cirrus.com> (raw)
Removal of child drivers and the bus driver was broken and would
result in a slew of various errors.
Most of these were caused by the code shutting down in the wrong
order, shutting down the bus driver first. The bus driver should
be shut down after the child drivers have been removed (compare
with the I2C and SPI subsystem for example).
These patches fix that.
A secondary problem was over the cleanup of child drivers. The
removal functions were not the opposite of the probe function,
and the ownership of struct sdw_slave is tricky because it mixes
two separate usages and currently has to be "owned" by the bus
driver.
Tested with 4 peripherals on 1 bus and 8 peripherals on 2 buses.
Richard Fitzgerald (7):
soundwire: bus: Do not forcibly disable child pm_runtime
soundwire: intel_init: Separate shutdown and cleanup
ASoC: SOF: Intel: Don't disable Soundwire interrupt before the bus has
shut down
soundwire: bus: Add remove callback to struct sdw_master_ops
soundwire: intel: Don't disable interrupt until children are removed
soundwire: intel: Don't disable pm_runtime until children are removed
soundwire: bus: Fix premature removal of sdw_slave objects
drivers/soundwire/bus.c | 37 ++++++++++++++++++++++++-----
drivers/soundwire/intel.c | 13 ++++++++--
drivers/soundwire/intel_init.c | 25 +++++++++++++++----
drivers/soundwire/slave.c | 21 ++++++++++++----
include/linux/soundwire/sdw.h | 3 ++-
include/linux/soundwire/sdw_intel.h | 2 ++
sound/soc/sof/intel/hda.c | 16 ++++++++++---
7 files changed, 96 insertions(+), 21 deletions(-)
--
2.30.2
next reply other threads:[~2022-09-07 10:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 10:13 Richard Fitzgerald [this message]
2022-09-07 10:13 ` [PATCH 1/7] soundwire: bus: Do not forcibly disable child pm_runtime Richard Fitzgerald
2022-09-12 10:43 ` Pierre-Louis Bossart
2022-09-07 10:13 ` [PATCH 2/7] soundwire: intel_init: Separate shutdown and cleanup Richard Fitzgerald
2022-09-07 10:13 ` [PATCH 3/7] ASoC: SOF: Intel: Don't disable Soundwire interrupt before the bus has shut down Richard Fitzgerald
2022-09-07 11:26 ` Mark Brown
2022-09-07 10:13 ` [PATCH 4/7] soundwire: bus: Add remove callback to struct sdw_master_ops Richard Fitzgerald
2022-09-07 10:14 ` [PATCH 5/7] soundwire: intel: Don't disable interrupt until children are removed Richard Fitzgerald
2022-09-12 10:53 ` Pierre-Louis Bossart
2022-09-12 15:36 ` Richard Fitzgerald
2022-09-12 17:12 ` Pierre-Louis Bossart
2022-09-13 9:29 ` Richard Fitzgerald
2022-09-07 10:14 ` [PATCH 6/7] soundwire: intel: Don't disable pm_runtime " Richard Fitzgerald
2022-09-07 10:14 ` [PATCH 7/7] soundwire: bus: Fix premature removal of sdw_slave objects Richard Fitzgerald
2022-09-12 10:57 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907101402.4685-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox