From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19947C6FA82 for ; Wed, 7 Sep 2022 13:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbiIGNP4 (ORCPT ); Wed, 7 Sep 2022 09:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbiIGNPe (ORCPT ); Wed, 7 Sep 2022 09:15:34 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8B23B8048D; Wed, 7 Sep 2022 06:15:15 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1oVutd-0000YC-00; Wed, 07 Sep 2022 15:15:13 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 8E9DDC0DBF; Wed, 7 Sep 2022 15:02:20 +0200 (CEST) Date: Wed, 7 Sep 2022 15:02:20 +0200 From: Thomas Bogendoerfer To: Alexander A Sverdlin Cc: Yu Zhao , Joe Perches , linux-mips@vger.kernel.org, Corey Minyard , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] MIPS: octeon: Get rid of preprocessor directives around RESERVE32 Message-ID: <20220907130220.GA17817@alpha.franken.de> References: <20220906083239.10163-1-alexander.sverdlin@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906083239.10163-1-alexander.sverdlin@nokia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 10:32:39AM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Some of them were pointless because CONFIG_CAVIUM_RESERVE32 is now always > defined, some were not enough (Yu Zhao reported > "Failed to allocate CAVIUM_RESERVE32 memory area" error). > > Removing the directives allows for compiler coverage of RESERVE32 code and > replacing one of [always-true] "ifdef" with a compiler conditional fixes > the [cosmetic] error message. > > Signed-off-by: Alexander Sverdlin > --- > > Changelog: > v2: > * Reduced the scope of addr variable > > arch/mips/cavium-octeon/executive/cvmx-cmd-queue.c | 4 ---- > arch/mips/cavium-octeon/setup.c | 27 +++++++++------------- applied to mips-fixes with Fixes: 3e3114ac460e ("MIPS: Introduce CAVIUM_RESERVE32 Kconfig option") added. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]