From: Hangyu Hua <hbh25y@gmail.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
changlianzhi@uniontech.com, dmitry.torokhov@gmail.com
Cc: linux-kernel@vger.kernel.org, Hangyu Hua <hbh25y@gmail.com>
Subject: [PATCH] tty: vt: add a bounds checking in vt_do_kdgkb_ioctl()
Date: Thu, 8 Sep 2022 15:54:03 +0800 [thread overview]
Message-ID: <20220908075403.27930-1-hbh25y@gmail.com> (raw)
As array_index_nospec's comments indicate，a bounds checking need to add
before calling array_index_nospec.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
drivers/tty/vt/keyboard.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
index be8313cdbac3..b9845455df79 100644
--- a/drivers/tty/vt/keyboard.c
+++ b/drivers/tty/vt/keyboard.c
@@ -2067,6 +2067,9 @@ int vt_do_kdgkb_ioctl(int cmd, struct kbsentry __user *user_kdgkb, int perm)
if (get_user(kb_func, &user_kdgkb->kb_func))
return -EFAULT;
+ if (kb_func >= MAX_NR_FUNC)
+ return -EFAULT;
+
kb_func = array_index_nospec(kb_func, MAX_NR_FUNC);
switch (cmd) {
--
2.34.1
next reply other threads:[~2022-09-08 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 7:54 Hangyu Hua [this message]
2022-09-08 8:10 ` [PATCH] tty: vt: add a bounds checking in vt_do_kdgkb_ioctl() Jiri Slaby
2022-09-09 2:02 ` Hangyu Hua
2022-09-08 8:16 ` Greg KH
2022-09-08 13:23 ` kernel test robot
2022-09-12 11:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908075403.27930-1-hbh25y@gmail.com \
--to=hbh25y@gmail.com \
--cc=changlianzhi@uniontech.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox