From: wuchi <wuchi.zero@gmail.com>
To: hch@lst.de, axboe@kernel.dk, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] relay: use kvcalloc to alloc page array in relay_alloc_page_array
Date: Fri, 9 Sep 2022 18:10:25 +0800 [thread overview]
Message-ID: <20220909101025.82955-1-wuchi.zero@gmail.com> (raw)
The kvcalloc is safer because it will check the integer overflows,
and using it will simple the logic of allocation size.
Signed-off-by: wuchi <wuchi.zero@gmail.com>
---
kernel/relay.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/relay.c b/kernel/relay.c
index 6a611e779e95..d7edc934c56d 100644
--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -60,10 +60,7 @@ static const struct vm_operations_struct relay_file_mmap_ops = {
*/
static struct page **relay_alloc_page_array(unsigned int n_pages)
{
- const size_t pa_size = n_pages * sizeof(struct page *);
- if (pa_size > PAGE_SIZE)
- return vzalloc(pa_size);
- return kzalloc(pa_size, GFP_KERNEL);
+ return kvcalloc(n_pages, sizeof(struct page *), GFP_KERNEL);
}
/*
--
2.20.1
next reply other threads:[~2022-09-09 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 10:10 wuchi [this message]
2022-09-09 21:48 ` [PATCH] relay: use kvcalloc to alloc page array in relay_alloc_page_array Andrew Morton
2022-09-10 14:24 ` chi wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909101025.82955-1-wuchi.zero@gmail.com \
--to=wuchi.zero@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox