From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Yevhen Orlov <yevhen.orlov@plvision.eu>,
netdev@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Mickey Rachamim <mickeyr@marvell.com>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-kernel@vger.kernel.org,
Yevhen Orlov <yevhen.orlov@plvision.eu>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Subject: Re: [PATCH net-next v5 1/9] net: marvell: prestera: Add router nexthops ABI
Date: Tue, 13 Sep 2022 12:13:24 +0300 [thread overview]
Message-ID: <202209111152.gf5xyKKy-lkp@intel.com> (raw)
In-Reply-To: <20220908225211.31482-2-yevhen.orlov@plvision.eu>
Hi Yevhen,
url: https://github.com/intel-lab-lkp/linux/commits/Yevhen-Orlov/net-marvell-prestera-add-nexthop-routes-offloading/20220909-065815
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9f8f1933dce555d3c246f447f54fca8de8889da9
config: openrisc-randconfig-m041-20220907 (https://download.01.org/0day-ci/archive/20220911/202209111152.gf5xyKKy-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/ethernet/marvell/prestera/prestera_hw.c:2139 prestera_hw_nhgrp_blk_get() error: uninitialized symbol 'err'.
vim +/err +2139 drivers/net/ethernet/marvell/prestera/prestera_hw.c
ec3daf86e28107 Yevhen Orlov 2022-09-09 2110 int prestera_hw_nhgrp_blk_get(struct prestera_switch *sw,
ec3daf86e28107 Yevhen Orlov 2022-09-09 2111 u8 *hw_state, u32 buf_size /* Buffer in bytes */)
ec3daf86e28107 Yevhen Orlov 2022-09-09 2112 {
ec3daf86e28107 Yevhen Orlov 2022-09-09 2113 struct prestera_msg_nh_chunk_req req;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2114 static struct prestera_msg_nh_chunk_resp resp;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2115 int err;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2116 u32 buf_offset;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2117
ec3daf86e28107 Yevhen Orlov 2022-09-09 2118 memset(&hw_state[0], 0, buf_size);
ec3daf86e28107 Yevhen Orlov 2022-09-09 2119 buf_offset = 0;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2120 while (1) {
ec3daf86e28107 Yevhen Orlov 2022-09-09 2121 if (buf_offset >= buf_size)
ec3daf86e28107 Yevhen Orlov 2022-09-09 2122 break;
Smatch always worries about zero sizes...
ec3daf86e28107 Yevhen Orlov 2022-09-09 2123
ec3daf86e28107 Yevhen Orlov 2022-09-09 2124 memset(&req, 0, sizeof(req));
ec3daf86e28107 Yevhen Orlov 2022-09-09 2125 req.offset = __cpu_to_le32(buf_offset * 8); /* 8 bits in u8 */
ec3daf86e28107 Yevhen Orlov 2022-09-09 2126 err = prestera_cmd_ret(sw,
ec3daf86e28107 Yevhen Orlov 2022-09-09 2127 PRESTERA_CMD_TYPE_ROUTER_NH_GRP_BLK_GET,
ec3daf86e28107 Yevhen Orlov 2022-09-09 2128 &req.cmd, sizeof(req), &resp.ret,
ec3daf86e28107 Yevhen Orlov 2022-09-09 2129 sizeof(resp));
ec3daf86e28107 Yevhen Orlov 2022-09-09 2130 if (err)
ec3daf86e28107 Yevhen Orlov 2022-09-09 2131 return err;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2132
ec3daf86e28107 Yevhen Orlov 2022-09-09 2133 memcpy(&hw_state[buf_offset], &resp.hw_state[0],
ec3daf86e28107 Yevhen Orlov 2022-09-09 2134 buf_offset + PRESTERA_MSG_CHUNK_SIZE > buf_size ?
ec3daf86e28107 Yevhen Orlov 2022-09-09 2135 buf_size - buf_offset : PRESTERA_MSG_CHUNK_SIZE);
ec3daf86e28107 Yevhen Orlov 2022-09-09 2136 buf_offset += PRESTERA_MSG_CHUNK_SIZE;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2137 }
ec3daf86e28107 Yevhen Orlov 2022-09-09 2138
ec3daf86e28107 Yevhen Orlov 2022-09-09 @2139 return err;
ec3daf86e28107 Yevhen Orlov 2022-09-09 2140 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-13 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 22:52 [PATCH net-next v5 0/9] net: marvell: prestera: add nexthop routes offloading Yevhen Orlov
2022-09-08 22:52 ` [PATCH net-next v5 1/9] net: marvell: prestera: Add router nexthops ABI Yevhen Orlov
2022-09-13 9:13 ` Dan Carpenter [this message]
2022-09-08 22:52 ` [PATCH net-next v5 2/9] net: marvell: prestera: Add cleanup of allocated fib_nodes Yevhen Orlov
2022-09-22 9:33 ` Paolo Abeni
2022-09-08 22:52 ` [PATCH net-next v5 3/9] net: marvell: prestera: Add strict cleanup of fib arbiter Yevhen Orlov
2022-09-08 22:52 ` [PATCH net-next v5 4/9] net: marvell: prestera: add delayed wq and flush wq on deinit Yevhen Orlov
2022-09-08 22:52 ` [PATCH net-next v5 5/9] net: marvell: prestera: Add length macros for prestera_ip_addr Yevhen Orlov
2022-09-08 22:52 ` [PATCH net-next v5 6/9] net: marvell: prestera: Add heplers to interact with fib_notifier_info Yevhen Orlov
2022-09-08 22:52 ` [PATCH net-next v5 7/9] net: marvell: prestera: add stub handler neighbour events Yevhen Orlov
2022-09-08 22:52 ` [PATCH net-next v5 8/9] net: marvell: prestera: Add neighbour cache accounting Yevhen Orlov
2022-09-13 9:27 ` Dan Carpenter
2022-09-08 22:52 ` [PATCH net-next v5 9/9] net: marvell: prestera: Propagate nh state from hw to kernel Yevhen Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209111152.gf5xyKKy-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=pabeni@redhat.com \
--cc=serhiy.pshyk@plvision.eu \
--cc=stephen@networkplumber.org \
--cc=taras.chornyi@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
--cc=yevhen.orlov@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox