Re: [PATCH 2/7] drm/msm: fix memory corruption with too many bridges

Johan Hovold
2022-09-13T07:49:33Z

On Mon, Sep 12, 2022 at 08:55:55PM +0300, Dmitry Baryshkov wrote:
> On 12/09/2022 18:40, Johan Hovold wrote:
> > Add the missing sanity checks on the bridge counter to avoid corrupting
> > data beyond the fixed-sized bridge array in case there are ever more
> > than eight bridges.
> >
> > a3376e3ec81c ("drm/msm: convert to drm_bridge")
> > ab5b0107ccf3 ("drm/msm: Initial add eDP support in msm drm driver (v5)")
> > a689554ba6ed ("drm/msm: Initial add DSI connector support")
>
> Most probably you've missed the Fixes: here.

Indeed, thanks for catching that.

> > Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable")
> > Cc: stable@vger.kernel.org # 3.12
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > drivers/gpu/drm/msm/dp/dp_display.c | 6 ++++++
> > drivers/gpu/drm/msm/dsi/dsi.c | 6 ++++++
> > drivers/gpu/drm/msm/hdmi/hdmi.c | 5 +++++
>
> Could you please split this into respective dp/dsi/hdmi patches. This
> will assist both the review and the stable team.

Yeah, you're right, that should help the stable team if nothing else.

> Otherwise LGTM.

Johan