From: Kees Cook <keescook@chromium.org>
To: Rich Felker <dalias@libc.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] sh: machvec: Use char[] for section boundaries
Date: Tue, 13 Sep 2022 10:34:21 -0700 [thread overview]
Message-ID: <202209131033.EDED655DA4@keescook> (raw)
In-Reply-To: <20220908221538.GD8773@brightrain.aerifal.cx>
On Thu, Sep 08, 2022 at 06:15:39PM -0400, Rich Felker wrote:
> On Wed, Sep 07, 2022 at 04:43:45PM -0700, Kees Cook wrote:
> > As done for other sections, define the extern as a character array,
> > which relaxes many of the compiler-time object size checks, which would
> > otherwise assume it's a single long. Solves the following build error:
> >
> > arch/sh/kernel/machvec.c: error: array subscript 'struct sh_machine_vector[0]' is partly outside array bounds of 'long int[1]' [-Werror=array-bounds]: => 105:33
>
> LGMT. This is the approach I recommend for this general type of
> mechanism. So,
>
> Acked-by: Rich Felker <dalias@libc.org>
>
> Since I haven't been on top of collating patches for upstreaming, I'd
> be happy if anyone else wants to take this in their tree before I get
> back to it.
Great; thanks! I'll take it via my tree. :)
-Kees
--
Kees Cook
prev parent reply other threads:[~2022-09-13 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 23:43 [PATCH] sh: machvec: Use char[] for section boundaries Kees Cook
2022-09-08 6:53 ` Geert Uytterhoeven
2022-09-08 12:17 ` Gustavo A. R. Silva
2022-09-08 22:15 ` Rich Felker
2022-09-13 17:34 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209131033.EDED655DA4@keescook \
--to=keescook@chromium.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=lethal@linux-sh.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox