From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, johan+linaro@kernel.org,
steev@kali.org
Subject: Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
Date: Tue, 13 Sep 2022 16:27:34 +0530 [thread overview]
Message-ID: <20220913105734.GD25849@workstation> (raw)
In-Reply-To: <YyBWZOMz3mKlje05@hovoldconsulting.com>
On Tue, Sep 13, 2022 at 12:07:32PM +0200, Johan Hovold wrote:
> [ Resend with Bjorn's address updated as the Linaro one now bounces. ]
>
> On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote:
> > The firmware location in linux-firmware has been changed to include the
> > SoC name. So use the updated location in Thinkpad devicetree.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I guess we should pick a commit prefix that we stick to for changes to
> this driver.
>
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s:
>
> is arguably unnecessarily long even if it follows the pattern of some
> other qcom dts.
>
> Shall we just use
>
> arm64: dts: qcom: sc8280xp-x13s:
This looks looks better. I did look into the earlier commits but I found
the prefix to be too long, so went with the last commit prefix.
>
> which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just
> keep the whole thing unchanged?
>
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > index c379650e52b1..3b7943d6e164 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > @@ -554,13 +554,13 @@ keyboard@68 {
> > };
> >
> > &remoteproc_adsp {
> > - firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
> >
> > status = "okay";
> > };
> >
> > &remoteproc_nsp0 {
> > - firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
> >
> > status = "okay";
> > };
>
> Change itself looks good otherwise:
>
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
>
Thanks! I will respin with the agreed prefix.
Regards,
Mani
> Johan
next prev parent reply other threads:[~2022-09-13 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 5:40 [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location Manivannan Sadhasivam
2022-09-13 10:00 ` Johan Hovold
2022-09-13 10:07 ` Johan Hovold
2022-09-13 10:57 ` Manivannan Sadhasivam [this message]
2022-09-13 20:13 ` Bjorn Andersson
2022-09-13 20:27 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913105734.GD25849@workstation \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox