* [PATCH v3] dt-bindings: mfd: qcom,tcsr: drop simple-mfd from IPQ6018
@ 2022-09-09 9:10 Krzysztof Kozlowski
2022-09-13 12:22 ` Rob Herring
2022-09-28 9:45 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-09 9:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Commit 7677ed11e9fa ("dt-bindings: mfd: qcom,tcsr: Convert to dtschema")
converted bindings to DT schema literally - including the
qcom,tcsr-ipq6018 expecting syscon and simple-mfd. Such configuration
is not used in DTS and there is no actual need of it. The TCSR block is
purely configuration block and should not have children. Any child
device should be simply moved outside of TCSR syscon block.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v2
================
1. Rebase on current MFD changes.
2. Split from the series. Nothing depends on it, AFAIK.
v2: https://lore.kernel.org/all/20220817145901.865977-2-krzysztof.kozlowski@linaro.org/
---
.../devicetree/bindings/mfd/qcom,tcsr.yaml | 46 +++++++++----------
1 file changed, 21 insertions(+), 25 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index d3c25daa995e..b12809b5cc22 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -15,31 +15,27 @@ description:
properties:
compatible:
- oneOf:
- - items:
- - enum:
- - qcom,msm8998-tcsr
- - qcom,qcs404-tcsr
- - qcom,sc7180-tcsr
- - qcom,sc7280-tcsr
- - qcom,sdm630-tcsr
- - qcom,sdm845-tcsr
- - qcom,sm8150-tcsr
- - qcom,tcsr-apq8064
- - qcom,tcsr-apq8084
- - qcom,tcsr-ipq8064
- - qcom,tcsr-mdm9615
- - qcom,tcsr-msm8660
- - qcom,tcsr-msm8916
- - qcom,tcsr-msm8953
- - qcom,tcsr-msm8960
- - qcom,tcsr-msm8974
- - qcom,tcsr-msm8996
- - const: syscon
- - items:
- - const: qcom,tcsr-ipq6018
- - const: syscon
- - const: simple-mfd
+ items:
+ - enum:
+ - qcom,msm8998-tcsr
+ - qcom,qcs404-tcsr
+ - qcom,sc7180-tcsr
+ - qcom,sc7280-tcsr
+ - qcom,sdm630-tcsr
+ - qcom,sdm845-tcsr
+ - qcom,sm8150-tcsr
+ - qcom,tcsr-apq8064
+ - qcom,tcsr-apq8084
+ - qcom,tcsr-ipq6018
+ - qcom,tcsr-ipq8064
+ - qcom,tcsr-mdm9615
+ - qcom,tcsr-msm8660
+ - qcom,tcsr-msm8916
+ - qcom,tcsr-msm8953
+ - qcom,tcsr-msm8960
+ - qcom,tcsr-msm8974
+ - qcom,tcsr-msm8996
+ - const: syscon
reg:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: mfd: qcom,tcsr: drop simple-mfd from IPQ6018
2022-09-09 9:10 [PATCH v3] dt-bindings: mfd: qcom,tcsr: drop simple-mfd from IPQ6018 Krzysztof Kozlowski
@ 2022-09-13 12:22 ` Rob Herring
2022-09-28 9:45 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-09-13 12:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Konrad Dybcio, Andy Gross, linux-kernel,
linux-arm-msm, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
On Fri, 09 Sep 2022 11:10:56 +0200, Krzysztof Kozlowski wrote:
> Commit 7677ed11e9fa ("dt-bindings: mfd: qcom,tcsr: Convert to dtschema")
> converted bindings to DT schema literally - including the
> qcom,tcsr-ipq6018 expecting syscon and simple-mfd. Such configuration
> is not used in DTS and there is no actual need of it. The TCSR block is
> purely configuration block and should not have children. Any child
> device should be simply moved outside of TCSR syscon block.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v2
> ================
> 1. Rebase on current MFD changes.
> 2. Split from the series. Nothing depends on it, AFAIK.
> v2: https://lore.kernel.org/all/20220817145901.865977-2-krzysztof.kozlowski@linaro.org/
> ---
> .../devicetree/bindings/mfd/qcom,tcsr.yaml | 46 +++++++++----------
> 1 file changed, 21 insertions(+), 25 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: mfd: qcom,tcsr: drop simple-mfd from IPQ6018
2022-09-09 9:10 [PATCH v3] dt-bindings: mfd: qcom,tcsr: drop simple-mfd from IPQ6018 Krzysztof Kozlowski
2022-09-13 12:22 ` Rob Herring
@ 2022-09-28 9:45 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2022-09-28 9:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On Fri, 09 Sep 2022, Krzysztof Kozlowski wrote:
> Commit 7677ed11e9fa ("dt-bindings: mfd: qcom,tcsr: Convert to dtschema")
> converted bindings to DT schema literally - including the
> qcom,tcsr-ipq6018 expecting syscon and simple-mfd. Such configuration
> is not used in DTS and there is no actual need of it. The TCSR block is
> purely configuration block and should not have children. Any child
> device should be simply moved outside of TCSR syscon block.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v2
> ================
> 1. Rebase on current MFD changes.
> 2. Split from the series. Nothing depends on it, AFAIK.
> v2: https://lore.kernel.org/all/20220817145901.865977-2-krzysztof.kozlowski@linaro.org/
> ---
> .../devicetree/bindings/mfd/qcom,tcsr.yaml | 46 +++++++++----------
> 1 file changed, 21 insertions(+), 25 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-28 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-09 9:10 [PATCH v3] dt-bindings: mfd: qcom,tcsr: drop simple-mfd from IPQ6018 Krzysztof Kozlowski
2022-09-13 12:22 ` Rob Herring
2022-09-28 9:45 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox