From: Bjorn Andersson <andersson@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/15] ARM: dts: qcom: msm8974: split TCSR halt regs out of mutex
Date: Tue, 13 Sep 2022 17:44:18 -0500 [thread overview]
Message-ID: <20220913224418.jvvguc66y5le7qjo@builder.lan> (raw)
In-Reply-To: <20220909092035.223915-11-krzysztof.kozlowski@linaro.org>
On Fri, Sep 09, 2022 at 11:20:30AM +0200, Krzysztof Kozlowski wrote:
[..]
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 90a6d4b7605c..ada232bed2c8 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1189,7 +1189,7 @@ remoteproc_mss: remoteproc@fc880000 {
> resets = <&gcc GCC_MSS_RESTART>;
> reset-names = "mss_restart";
>
> - qcom,halt-regs = <&tcsr_mutex_block 0x1180 0x1200 0x1280>;
> + qcom,halt-regs = <&tcsr_1 0x180 0x200 0x280>;
>
> qcom,smem-states = <&modem_smp2p_out 0>;
> qcom,smem-state-names = "stop";
> @@ -1230,10 +1230,15 @@ smd-edge {
>
> tcsr_mutex_block: syscon@fd484000 {
> compatible = "syscon";
> - reg = <0xfd484000 0x2000>;
> + reg = <0xfd484000 0x1000>;
> };
>
> - tcsr: syscon@fd4a0000 {
> + tcsr_1: syscon@fd485000 {
While the accessed registers look general purpose in nature, I would
prefer that we stick with naming it based on the register blocks - and
this is part of what's named "tcsr_mutex".
Is it not possible to claim that this region is a
"qcom,msm8974-tcsr-mutex" and a "syscon"?
> + compatible = "qcom,tcsr-msm8974", "syscon";
> + reg = <0xfd485000 0x1000>;
> + };
> +
> + tcsr_2: syscon@fd4a0000 {
And I would like to keep this as "tcsr".
Regards,
Bjorn
next prev parent reply other threads:[~2022-09-13 22:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 9:20 [PATCH v3 00/15] ARM/hwlock: qcom: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 01/15] dt-bindings: hwlock: qcom-hwspinlock: add support for MMIO on older SoCs Krzysztof Kozlowski
2022-09-13 12:50 ` Rob Herring
2022-09-09 9:20 ` [PATCH v3 02/15] dt-bindings: hwlock: qcom-hwspinlock: correct example indentation Krzysztof Kozlowski
2022-09-13 12:51 ` Rob Herring
2022-09-09 9:20 ` [PATCH v3 03/15] hwspinlock: qcom: correct MMIO max register for newer SoCs Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 04/15] hwspinlock: qcom: add support for MMIO on older SoCs Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 05/15] arm64: dts: qcom: ipq6018: add missing TCSR syscon compatible Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 06/15] arm64: dts: qcom: msm8953: " Krzysztof Kozlowski
2022-09-13 22:36 ` Bjorn Andersson
2022-09-09 9:20 ` [PATCH v3 07/15] arm64: dts: qcom: qcs404: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 08/15] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-19 22:13 ` Dmitry Baryshkov
2022-09-20 13:04 ` Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 09/15] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 10/15] ARM: dts: qcom: msm8974: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-09-13 22:44 ` Bjorn Andersson [this message]
2022-09-15 14:49 ` Krzysztof Kozlowski
2022-09-19 21:01 ` Bjorn Andersson
2022-09-09 9:20 ` [PATCH v3 11/15] arm64: dts: qcom: ipq6018: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 12/15] arm64: dts: qcom: msm8994: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 13/15] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 14/15] ARM: dts: qcom: apq8084: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 15/15] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
2022-09-13 22:43 ` (subset) [PATCH v3 00/15] ARM/hwlock: qcom: " Bjorn Andersson
2022-09-13 22:48 ` Bjorn Andersson
2022-09-19 22:14 ` Dmitry Baryshkov
2022-09-27 3:34 ` Bjorn Andersson
2022-09-27 3:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913224418.jvvguc66y5le7qjo@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox