From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED78ECAAA1 for ; Fri, 16 Sep 2022 15:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbiIPPJ1 (ORCPT ); Fri, 16 Sep 2022 11:09:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231625AbiIPPJU (ORCPT ); Fri, 16 Sep 2022 11:09:20 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59C64A98EA for ; Fri, 16 Sep 2022 08:09:19 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id b23so21503982pfp.9 for ; Fri, 16 Sep 2022 08:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=4R00t3D0GnXDRz5F9l2Kk2rqoyZp2jq6sAMUbdTmoVQ=; b=Gq1QrMj4uW2owlgOsg2RS/vKPgdQquRZQhOsCEk8Oeu+QOA4LHi48cczbWLplZil/3 F+5j48hd8IDyIHR/kMrltGLRa5rzU4FsDd4cHfB/5wtQuDKw2ydH/gCExHFM7rl+7Fq4 xd/xx9vXTejXOSfnQe0Da6IrqJeCIuqd9l7KE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=4R00t3D0GnXDRz5F9l2Kk2rqoyZp2jq6sAMUbdTmoVQ=; b=fyvZpDNQ2XxU5iVzNIrYkrX5oyJ5mNpnvmqx0oSiH5OpYBOcLrcCFFNO2g9oHyHE3B IgeAVB5q22DPq0j+OHTp/YjaQe4P4C7IIPzeuCTaUsUQFUKcoZm3Mv46JNoTaGVbTXZd oevfZKEPnqzxpPKwyKUXgHy55eu8CUkgrgXCbBwKLZxs00DRW1t+1nmXCx5XKQq+tDU5 VyXdJX2Sg3nG9QtChY8Pb9091VoT/i50HHtjPZemQaUiEbvWXn2XEK+CJ8PUY5jIjEKG 3EB7RcLTu3EUaWutIBueF9z+ftOJEtvcxMMS+n/eoxjtTtvotunCgZSxbcD9BymGniXY 71HA== X-Gm-Message-State: ACrzQf3K2YrIa1hLsqv75V2s83032RndjCQNjXiqn9RlvXiFSrkhe87w bAtQaeg0mHDxu0RCYEaa/cARpg== X-Google-Smtp-Source: AMsMyM43t4mawdkrjwz+XsE+S9srFkgpjDkolkxGjJeOl5juIi7HKJJ2I/Oi3erFUtfSUa2N10eBIw== X-Received: by 2002:a05:6a00:8cc:b0:52c:7ab5:2ce7 with SMTP id s12-20020a056a0008cc00b0052c7ab52ce7mr5265285pfu.28.1663340958813; Fri, 16 Sep 2022 08:09:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w14-20020a17090aea0e00b00200558540a3sm1596538pjy.53.2022.09.16.08.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 08:09:17 -0700 (PDT) Date: Fri, 16 Sep 2022 08:09:16 -0700 From: Kees Cook To: Matthew Wilcox Cc: Uladzislau Rezki , Andrew Morton , Yu Zhao , dev@der-flo.net, linux-mm@kvack.org, linux-hardening@vger.kernel.org, Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, linux-perf-users@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 3/3] usercopy: Add find_vmap_area_try() to avoid deadlocks Message-ID: <202209160805.CA47B2D673@keescook> References: <20220916135953.1320601-1-keescook@chromium.org> <20220916135953.1320601-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 03:46:07PM +0100, Matthew Wilcox wrote: > On Fri, Sep 16, 2022 at 06:59:57AM -0700, Kees Cook wrote: > > The check_object_size() checks under CONFIG_HARDENED_USERCOPY need to be > > more defensive against running from interrupt context. Use a best-effort > > check for VMAP areas when running in interrupt context > > I had something more like this in mind: Yeah, I like -EAGAIN. I'd like to keep the interrupt test to choose lock vs trylock, otherwise it's trivial to bypass the hardening test by having all the other CPUs beating on the spinlock. Thanks! -Kees -- Kees Cook