From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA9CCECAAA1 for ; Sat, 17 Sep 2022 00:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbiIQAG5 (ORCPT ); Fri, 16 Sep 2022 20:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbiIQAGy (ORCPT ); Fri, 16 Sep 2022 20:06:54 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0480BBA7B for ; Fri, 16 Sep 2022 17:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663373213; x=1694909213; h=date:from:to:cc:subject:message-id:mime-version; bh=IaAYQuCd4DTg2czBQT7OG/4TqdOhFuSu8hSX3DSAk3Q=; b=hB07Z8Z2kolcDhUVQInqcBxnrIN6Ux9n0XL4qHPE30s/VKtDFIXiiLqH 6jAUyDFbE/CmYW/c5X3mXx6RdoeVT1JaFzDp0fqzW7HeDWgbXzbS9XNrP ZIMYgMk/IT94eyUwqccvT9/kBxFvDqys2Aq5ania8R3M7yvU/G0SlzPS/ WHNPpqJ2ymSEne6DX+ZAyYbvE9dIWInOB9MfDFvZOL/TXhUkD6oDt63wU bwP1Kn0IlKTdskUnOUKGD92fUv6+mFvgrrUYDF1T+JELq8tpa9hwkxj7X nV9t72MUGuXnRF5vXYmBmKyNg1qs2Ce3fbJ7sJ23a5djTpNpgYwQZd+MM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10472"; a="325381661" X-IronPort-AV: E=Sophos;i="5.93,321,1654585200"; d="scan'208";a="325381661" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2022 17:06:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,321,1654585200"; d="scan'208";a="946559282" Received: from lkp-server02.sh.intel.com (HELO 41300c7200ea) ([10.239.97.151]) by fmsmga005.fm.intel.com with ESMTP; 16 Sep 2022 17:06:48 -0700 Received: from kbuild by 41300c7200ea with local (Exim 4.96) (envelope-from ) id 1oZLM7-0002HT-1e; Sat, 17 Sep 2022 00:06:47 +0000 Date: Sat, 17 Sep 2022 08:06:02 +0800 From: kernel test robot To: Moshe Tal Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Saeed Mahameed , Tariq Toukan Subject: drivers/net/ethernet/mellanox/mlx5/core/en_main.c:3466:12: warning: stack frame size (1068) exceeds limit (1024) in 'mlx5e_setup_tc' Message-ID: <202209170705.iboWVVE6-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Moshe, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a335366bad1364a07f49df9da1fdfa6d411a5f39 commit: 0bb7228f7096d760252eb6948e2858376d628062 net/mlx5e: Fix mqprio_rl handling on devlink reload date: 8 weeks ago config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220917/202209170705.iboWVVE6-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0bb7228f7096d760252eb6948e2858376d628062 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 0bb7228f7096d760252eb6948e2858376d628062 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/ net/netfilter/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:3466:12: warning: stack frame size (1068) exceeds limit (1024) in 'mlx5e_setup_tc' [-Wframe-larger-than] static int mlx5e_setup_tc(struct net_device *dev, enum tc_setup_type type, ^ 1 warning generated. vim +/mlx5e_setup_tc +3466 drivers/net/ethernet/mellanox/mlx5/core/en_main.c 955bcb6ea0df0d Pablo Neira Ayuso 2019-07-09 3465 9afe9a53537789 Or Gerlitz 2018-01-01 @3466 static int mlx5e_setup_tc(struct net_device *dev, enum tc_setup_type type, de4784ca030fed Jiri Pirko 2017-08-07 3467 void *type_data) 0cf0f6d3d39672 Jiri Pirko 2017-08-07 3468 { 4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3469 struct mlx5e_priv *priv = netdev_priv(dev); 2ff349c5edfe3e Roi Dayan 2020-09-16 3470 bool tc_unbind = false; 214baf22870cfa Maxim Mikityanskiy 2021-01-19 3471 int err; 4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3472 2ff349c5edfe3e Roi Dayan 2020-09-16 3473 if (type == TC_SETUP_BLOCK && 2ff349c5edfe3e Roi Dayan 2020-09-16 3474 ((struct flow_block_offload *)type_data)->command == FLOW_BLOCK_UNBIND) 2ff349c5edfe3e Roi Dayan 2020-09-16 3475 tc_unbind = true; 2ff349c5edfe3e Roi Dayan 2020-09-16 3476 2ff349c5edfe3e Roi Dayan 2020-09-16 3477 if (!netif_device_present(dev) && !tc_unbind) 2ff349c5edfe3e Roi Dayan 2020-09-16 3478 return -ENODEV; 2ff349c5edfe3e Roi Dayan 2020-09-16 3479 0cf0f6d3d39672 Jiri Pirko 2017-08-07 3480 switch (type) { daa664a5cdd599 Vlad Buslov 2019-08-29 3481 case TC_SETUP_BLOCK: { daa664a5cdd599 Vlad Buslov 2019-08-29 3482 struct flow_block_offload *f = type_data; daa664a5cdd599 Vlad Buslov 2019-08-29 3483 c9f14470d04830 Vlad Buslov 2019-08-26 3484 f->unlocked_driver_cb = true; 955bcb6ea0df0d Pablo Neira Ayuso 2019-07-09 3485 return flow_block_cb_setup_simple(type_data, 955bcb6ea0df0d Pablo Neira Ayuso 2019-07-09 3486 &mlx5e_block_cb_list, 4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3487 mlx5e_setup_tc_block_cb, 4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3488 priv, priv, true); daa664a5cdd599 Vlad Buslov 2019-08-29 3489 } 575ed7d39e2fbe Nogah Frankel 2017-11-06 3490 case TC_SETUP_QDISC_MQPRIO: e2aeac448f06ac Tariq Toukan 2021-07-06 3491 mutex_lock(&priv->state_lock); e2aeac448f06ac Tariq Toukan 2021-07-06 3492 err = mlx5e_setup_tc_mqprio(priv, type_data); e2aeac448f06ac Tariq Toukan 2021-07-06 3493 mutex_unlock(&priv->state_lock); e2aeac448f06ac Tariq Toukan 2021-07-06 3494 return err; 214baf22870cfa Maxim Mikityanskiy 2021-01-19 3495 case TC_SETUP_QDISC_HTB: 214baf22870cfa Maxim Mikityanskiy 2021-01-19 3496 mutex_lock(&priv->state_lock); 214baf22870cfa Maxim Mikityanskiy 2021-01-19 3497 err = mlx5e_setup_tc_htb(priv, type_data); 214baf22870cfa Maxim Mikityanskiy 2021-01-19 3498 mutex_unlock(&priv->state_lock); 214baf22870cfa Maxim Mikityanskiy 2021-01-19 3499 return err; 0cf0f6d3d39672 Jiri Pirko 2017-08-07 3500 default: 0cf0f6d3d39672 Jiri Pirko 2017-08-07 3501 return -EOPNOTSUPP; 0cf0f6d3d39672 Jiri Pirko 2017-08-07 3502 } 08fb1dacdd7634 Saeed Mahameed 2016-02-22 3503 } 08fb1dacdd7634 Saeed Mahameed 2016-02-22 3504 :::::: The code at line 3466 was first introduced by commit :::::: 9afe9a5353778994d4396f3d5ff639221bfa5cc9 net/mlx5e: Eliminate build warnings on no previous prototype :::::: TO: Or Gerlitz :::::: CC: Saeed Mahameed -- 0-DAY CI Kernel Test Service https://01.org/lkp