From: Jonathan Cameron <jic23@kernel.org>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andrea Merello <andrea.merello@iit.it>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Matt Ranostay <matt.ranostay@konsulko.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
jmondi <jacopo@jmondi.org>, Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [v7 13/14] iio: imu: add BNO055 I2C driver
Date: Sun, 18 Sep 2022 18:26:26 +0100 [thread overview]
Message-ID: <20220918182626.00aae26d@jic23-huawei> (raw)
In-Reply-To: <CAN8YU5MbGWbE6nRBCs3gYwyN2yYk7OsmaQsTrZvJctQOhgLBng@mail.gmail.com>
On Thu, 8 Sep 2022 08:42:01 +0200
Andrea Merello <andrea.merello@gmail.com> wrote:
> > Hmm... It has my tag but I have noticed something to improve.
>
> One comment below, OK for the rest.
>
> > ...
> >
> > > +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */
> >
> > Can we elaborate what to fix and why it can't be fixed right now?
>
> Ah, this is a stale comment; I'll drop it..
I fixed up Andy's comments on this patch whilst applying.
Thanks,
Jonathan
next prev parent reply other threads:[~2022-09-18 17:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 13:21 [v7 00/14] Add support for Bosch BNO055 IMU andrea.merello
2022-09-07 13:21 ` [v7 01/14] iio: add modifiers for linear acceleration andrea.merello
2022-09-07 13:21 ` [v7 02/14] iio: document linear acceleration modifiers andrea.merello
2022-09-07 13:21 ` [v7 03/14] iio: event_monitor: add " andrea.merello
2022-09-07 13:21 ` [v7 04/14] iio: add modifers for pitch, yaw, roll andrea.merello
2022-09-07 13:21 ` [v7 05/14] iio: document pitch, yaw, roll modifiers andrea.merello
2022-09-07 13:21 ` [v7 06/14] iio: event_monitor: add pitch, yaw and " andrea.merello
2022-09-07 13:21 ` [v7 07/14] iio: add support for binary attributes andrea.merello
2022-09-07 13:21 ` [v7 08/14] iio: imu: add Bosch Sensortec BNO055 core driver andrea.merello
2022-09-18 17:27 ` Jonathan Cameron
2022-09-23 7:25 ` Andrea Merello
2022-09-07 13:22 ` [v7 09/14] iio: document bno055 private sysfs attributes andrea.merello
2022-09-07 13:22 ` [v7 10/14] iio: document "serialnumber" sysfs attribute andrea.merello
2022-09-07 13:22 ` [v7 11/14] dt-bindings: iio/imu: Add Bosch BNO055 andrea.merello
2022-09-07 13:22 ` [v7 12/14] iio: imu: add BNO055 serdev driver andrea.merello
2022-09-07 13:22 ` [v7 13/14] iio: imu: add BNO055 I2C driver andrea.merello
2022-09-07 14:09 ` Andy Shevchenko
2022-09-08 6:42 ` Andrea Merello
2022-09-18 17:26 ` Jonathan Cameron [this message]
2022-09-07 13:22 ` [v7 14/14] docs: iio: add documentation for BNO055 driver andrea.merello
2022-09-07 14:12 ` [v7 00/14] Add support for Bosch BNO055 IMU Andy Shevchenko
2022-09-18 17:30 ` Jonathan Cameron
2022-09-08 3:47 ` Bagas Sanjaya
2022-09-08 6:51 ` Andrea Merello
2022-09-08 7:32 ` Bagas Sanjaya
2022-09-08 12:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220918182626.00aae26d@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrea.merello@gmail.com \
--cc=andrea.merello@iit.it \
--cc=andy.shevchenko@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox