From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3610AC54EE9 for ; Mon, 19 Sep 2022 14:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbiISOv3 (ORCPT ); Mon, 19 Sep 2022 10:51:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229606AbiISOvI (ORCPT ); Mon, 19 Sep 2022 10:51:08 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E348E32EE4; Mon, 19 Sep 2022 07:51:07 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1oaI6u-0005ft-01; Mon, 19 Sep 2022 16:51:00 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 23F18C12F2; Mon, 19 Sep 2022 16:47:47 +0200 (CEST) Date: Mon, 19 Sep 2022 16:47:47 +0200 From: Thomas Bogendoerfer To: Kelvin Cheung Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Alexandru Ardelean , Serge Semin Subject: Re: [PATCH v2] MIPS: Loongson32: Fix PHY-mode being left unspecified Message-ID: <20220919144747.GA7674@alpha.franken.de> References: <20220911161009.34453-1-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220911161009.34453-1-keguang.zhang@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2022 at 12:10:09AM +0800, Kelvin Cheung wrote: > From: Serge Semin > > commit 0060c8783330 ("net: stmmac: implement support for passive mode > converters via dt") has changed the plat->interface field semantics from > containing the PHY-mode to specifying the MAC-PCS interface mode. Due to > that the loongson32 platform code will leave the phylink interface > uninitialized with the PHY-mode intended by the means of the actual > platform setup. The commit-author most likely has just missed the > arch-specific code to fix. Let's mend the Loongson32 platform code then by > assigning the PHY-mode to the phy_interface field of the STMMAC platform > data. > > Fixes: 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt") > Signed-off-by: Serge Semin > Signed-off-by: Keguang Zhang > Tested-by: Keguang Zhang > --- > V1 -> V2: Add my SoB tag > --- > arch/mips/loongson32/common/platform.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]