From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>, <novikov@ispras.ru>,
<vasilyev@ispras.ru>, <kirill.shilimanov@huawei.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: intel: Remove macro that is already defined in the core
Date: Tue, 20 Sep 2022 10:10:22 +0200 [thread overview]
Message-ID: <20220920101022.7bfa5304@xps-13> (raw)
In-Reply-To: <20220801025740.47191-1-tudor.ambarus@microchip.com>
Hi Tudor,
tudor.ambarus@microchip.com wrote on Mon, 1 Aug 2022 05:57:40 +0300:
> NAND_DATA_IFACE_CHECK_ONLY is already defined in
> include/linux/mtd/rawnand.h. The intel driver includes
> <linux/mtd/rawnand.h>, so remove the duplicate definition from the intel
> driver.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/nand/raw/intel-nand-controller.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c
> index 7c1c80dae826..fbf6731420d6 100644
> --- a/drivers/mtd/nand/raw/intel-nand-controller.c
> +++ b/drivers/mtd/nand/raw/intel-nand-controller.c
> @@ -99,8 +99,6 @@
>
> #define HSNAND_ECC_OFFSET 0x008
>
> -#define NAND_DATA_IFACE_CHECK_ONLY -1
> -
> #define MAX_CS 2
>
> #define USEC_PER_SEC 1000000L
Actually I already received a series which contains a patch doing
exactly that. But thanks anyway :-)
Cheers,
Miquèl
prev parent reply other threads:[~2022-09-20 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 2:57 [PATCH] mtd: rawnand: intel: Remove macro that is already defined in the core Tudor Ambarus
2022-09-20 8:10 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920101022.7bfa5304@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=kirill.shilimanov@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=novikov@ispras.ru \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vasilyev@ispras.ru \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox