From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE2AAC54EE9 for ; Tue, 20 Sep 2022 11:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbiITLoU (ORCPT ); Tue, 20 Sep 2022 07:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230184AbiITLn6 (ORCPT ); Tue, 20 Sep 2022 07:43:58 -0400 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [IPv6:2a01:37:1000::53df:5f64:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6110A74BBB; Tue, 20 Sep 2022 04:43:37 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id B93893000244E; Tue, 20 Sep 2022 13:43:31 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id ADB6D2D939; Tue, 20 Sep 2022 13:43:31 +0200 (CEST) Date: Tue, 20 Sep 2022 13:43:31 +0200 From: Lukas Wunner To: Lino Sanfilippo Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, u.kleine-koenig@pengutronix.de, linux@armlinux.org.uk, richard.genoud@gmail.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, p.rosenberger@kunbus.com Subject: Re: Move RS485 implementation from drivers to serial core (v4 RESEND) Message-ID: <20220920114331.GA26352@wunner.de> References: <20220410104642.32195-1-LinoSanfilippo@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410104642.32195-1-LinoSanfilippo@gmx.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 10, 2022 at 12:46:33PM +0200, Lino Sanfilippo wrote: > This patch series is an attempt to simplify rs485 implementation in drivers > by moving the following tasks out of the drivers into the serial core: > > - ensure sane RTS settings: in case of an invalid configuration (both RTS > after send and RTS on send set or both unset) enable RTS on send and > disable RTS after send [...] > Redundant code has been removed from the following drivers for now: > > - atmel > - fsl_lpuart > - amba > - imx > - max310x > - omap-serial > - sc16is7xx > - stm32-usart It looks like there's more of this cruft left at least in serial8250_em485_config()... Thanks, Lukas