From: Jacopo Mondi <jacopo@jmondi.org>
To: Rafael Mendonca <rafaelmendsr@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov5648: Free V4L2 fwnode data on unbind
Date: Tue, 20 Sep 2022 14:46:35 +0200 [thread overview]
Message-ID: <20220920124635.jhprooo67daaivq7@lati> (raw)
In-Reply-To: <20220919023247.731106-1-rafaelmendsr@gmail.com>
Hi Rafael
On Sun, Sep 18, 2022 at 11:32:46PM -0300, Rafael Mendonca wrote:
> The V4L2 fwnode data structure doesn't get freed on unbind, which leads to
> a memleak.
>
> Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> drivers/media/i2c/ov5648.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> index dfcd33e9ee13..95850f06112b 100644
> --- a/drivers/media/i2c/ov5648.c
> +++ b/drivers/media/i2c/ov5648.c
> @@ -2598,6 +2598,8 @@ static int ov5648_remove(struct i2c_client *client)
> mutex_destroy(&sensor->mutex);
> media_entity_cleanup(&subdev->entity);
>
> + v4l2_fwnode_endpoint_free(&sensor->endpoint);
> +
Nit: all the other function calls are in a single block, this one
doesn't deserve an empty line before it.
Nit apart, the patch is a good fix.
> return 0;
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-09-20 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 2:32 [PATCH] media: i2c: ov5648: Free V4L2 fwnode data on unbind Rafael Mendonca
2022-09-19 14:32 ` Tommaso Merciai
2022-09-20 12:46 ` Jacopo Mondi [this message]
2022-09-20 13:25 ` Paul Kocialkowski
2022-09-20 13:58 ` Rafael Mendonca
2022-09-20 14:07 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920124635.jhprooo67daaivq7@lati \
--to=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=rafaelmendsr@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox