Re: [RFC PATCH v2 19/20] nvmem: layouts: rewrite the u-boot-env driver as a NVMEM layout

Miquel Raynal
2022-09-21T10:37:59Z

Hi Michael,

michael@walle.cc wrote on Fri, 2 Sep 2022 00:18:56 +0200:

> Instead of hardcoding the underlying access method mtd_read() and
> duplicating all the error handling, rewrite the driver as a nvmem
> layout which just uses nvmem_device_read() and thus works with any
> NVMEM device.
>
> But because this is now not a device anymore, the compatible string
> will have to be changed so the device will still be probed:
> compatible = "u-boot,env";
> to
> compatible = "u-boot,env", "nvmem-cells";
>
> "nvmem-cells" will tell the mtd layer to register a nvmem_device().
> "u-boot,env" will tell the NVMEM that it should apply the u-boot
> environment layout to the NVMEM device.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> changes since v1:
> - none
>
> drivers/nvmem/layouts/Kconfig | 8 ++
> drivers/nvmem/layouts/Makefile | 1 +
> drivers/nvmem/layouts/u-boot-env.c | 144 +++++++++++++++++++
> drivers/nvmem/u-boot-env.c | 218 -----------------------------

Nit: IIRC there is a MAINTAINERS entry to update as well.

Thanks,
Miquèl