public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Philippe Schenker <dev@pschenker.ch>
To: dri-devel@lists.freedesktop.org,
	Adrien Grassein <adrien.grassein@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Robert Foss <robert.foss@linaro.org>,
	linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	David Airlie <airlied@linux.ie>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Philippe Schenker <philippe.schenker@toradex.com>
Subject: [PATCH 3/4] drm/bridge: lt8912b: fix corrupted image output
Date: Thu, 22 Sep 2022 14:43:05 +0200	[thread overview]
Message-ID: <20220922124306.34729-4-dev@pschenker.ch> (raw)
In-Reply-To: <20220922124306.34729-1-dev@pschenker.ch>

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Correct I2C address for the register list in lt8912_write_lvds_config(),
these registers are on the first I2C address (0x48), the current
function is just writing garbage to the wrong registers and this creates
multiple issues (artifacts and output completely corrupted) on some HDMI
displays.

Correct I2C address comes from Lontium documentation and it is the one
used on other out-of-tree LT8912B drivers [1].

[1] https://github.com/boundarydevices/linux/blob/boundary-imx_5.10.x_2.0.0/drivers/video/lt8912.c#L296

Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
---

 drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 6a4bb7422176..5968f4af190b 100644
--- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
+++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
@@ -188,7 +188,7 @@ static int lt8912_write_lvds_config(struct lt8912 *lt)
 		{0x03, 0xff},
 	};
 
-	return regmap_multi_reg_write(lt->regmap[I2C_CEC_DSI], seq, ARRAY_SIZE(seq));
+	return regmap_multi_reg_write(lt->regmap[I2C_MAIN], seq, ARRAY_SIZE(seq));
 };
 
 static inline struct lt8912 *bridge_to_lt8912(struct drm_bridge *b)
-- 
2.37.3


  parent reply	other threads:[~2022-09-22 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 12:43 [PATCH 0/4] drm/bridge: lt8912b: Fix corrupt display output due to wrong bridge config Philippe Schenker
2022-09-22 12:43 ` [PATCH 1/4] drm/bridge: lt8912b: add vsync hsync Philippe Schenker
2022-09-22 18:24   ` Adrien Grassein
2022-09-22 12:43 ` [PATCH 2/4] drm/bridge: lt8912b: set hdmi or dvi mode Philippe Schenker
2022-09-22 18:25   ` Adrien Grassein
2022-09-22 12:43 ` Philippe Schenker [this message]
2022-09-22 18:26   ` [PATCH 3/4] drm/bridge: lt8912b: fix corrupted image output Adrien Grassein
2022-09-22 12:43 ` [PATCH 4/4] drm/bridge: lt8912b: clarify lvds output status Philippe Schenker
2022-09-22 18:26   ` Adrien Grassein
2022-09-23  9:22 ` (subset) [PATCH 0/4] drm/bridge: lt8912b: Fix corrupt display output due to wrong bridge config Neil Armstrong
2022-09-23  9:25 ` Neil Armstrong
2022-09-28 14:22 ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922124306.34729-4-dev@pschenker.ch \
    --to=dev@pschenker.ch \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=adrien.grassein@gmail.com \
    --cc=airlied@linux.ie \
    --cc=andrzej.hajda@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francesco.dolcini@toradex.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=philippe.schenker@toradex.com \
    --cc=robert.foss@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox