From: Ali Saidi <alisaidi@amazon.com>
To: <renyu.zj@linux.alibaba.com>
Cc: <acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
<alisaidi@amazon.com>, <german.gomez@arm.com>,
<james.clark@arm.com>, <john.garry@huawei.com>,
<jolsa@kernel.org>, <leo.yan@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>, <mark.rutland@arm.com>,
<mike.leach@linaro.org>, <mingo@redhat.com>,
<namhyung@kernel.org>, <peterz@infradead.org>,
<timothy.hayes@arm.com>, <will@kernel.org>,
<xueshuai@linux.alibaba.com>, <zhuo.song@linux.alibaba.com>
Subject: Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
Date: Mon, 26 Sep 2022 14:10:32 +0000 [thread overview]
Message-ID: <20220926141032.30734-1-alisaidi@amazon.com> (raw)
In-Reply-To: <1664197396-42672-1-git-send-email-renyu.zj@linux.alibaba.com>
> When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> arm-spe: Use SPE data source for neoverse cores") augment the type with
> source information by MIDR. However, is_midr_in_range only compares the
> first entry in neoverse_spe.
>
> Change is_midr_in_range to is_midr_in_range_list to traverse the
> neoverse_spe array so that all neoverse cores synthesize event with data
> source packet.
>
> Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
Thanks for catching this, you're absolutely right.
Reviewed-by: Ali Saidi <alisaidi@amazon.com>
Ali
next prev parent reply other threads:[~2022-09-26 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 13:03 [PATCH] perf arm-spe: augment the data source type with neoverse_spe list Jing Zhang
2022-09-26 14:10 ` Ali Saidi [this message]
2022-09-26 15:00 ` Leo Yan
2022-09-28 14:20 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926141032.30734-1-alisaidi@amazon.com \
--to=alisaidi@amazon.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=timothy.hayes@arm.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox