From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A18D9C32771 for ; Mon, 26 Sep 2022 22:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231383AbiIZWD6 (ORCPT ); Mon, 26 Sep 2022 18:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbiIZWD3 (ORCPT ); Mon, 26 Sep 2022 18:03:29 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18E64F34CD for ; Mon, 26 Sep 2022 15:02:59 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id w20so7434226ply.12 for ; Mon, 26 Sep 2022 15:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=iG5IW0JSXvDHPUhBmm25KDoROGtwoeP9Wl6CEV+mS6Q=; b=bH3XVvyeNNuMBwR/KDblcgO2wUIe3I4i4JFu4GLyRW3ThKNDfrBq05Phn4EHue23/P tawL2FBLBw21ueE0Kq/yI94WBlcQv70rR0t2LTm8B0fHFZmExa3SKYQIjulYbRs/0Tj1 luG85TwnLv50EaLXnj7tN3qys76U5cG24DrVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=iG5IW0JSXvDHPUhBmm25KDoROGtwoeP9Wl6CEV+mS6Q=; b=XopjIYK5kU9Pd5BoxLsMAr9+b1S8mNLjWNSFrwM63F7Gi45N1d6EgKfYji6OG7027a J9LZCBSKOI3VX7RCotZagotJlw16GEnC7XUjRObrlOTreuAcYLb8QSz8xNdpoaLN0Btd N4VrQTNtaWYO4bEnBAZOtROtWaEd8wjBcj446tOtCcvjYW3Ak3yhvxWPHD2IKGbqTe3a 4RKsxaaJBz2LD2/zvs6aX0kICGSL4kNhdVCzyfpCvxyvEp9aejV7x3xc0OM784557yza TzHrFmSI59Z6H0fdN4r2BXcWpMKY3kko99K4kM1DvaU3G8eA0p9p32zAvK2YG1d3S5Wj ataQ== X-Gm-Message-State: ACrzQf3GeO0Bqk0NI6IhEetnU7zZ2uMc473nDGW+eS+qW3NIc5ufGNSm LiNzEqoD2GC5YmrWV/Y7HkN0Jg== X-Google-Smtp-Source: AMsMyM6wNgrqDvRAOHLQVvZqYe6L7XT9isBSFukx03A5p2O37KxwRQFvgSB4cvWDSBH8916sJcBvCA== X-Received: by 2002:a17:90a:6441:b0:203:6aa1:56f8 with SMTP id y1-20020a17090a644100b002036aa156f8mr888487pjm.25.1664229778898; Mon, 26 Sep 2022 15:02:58 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id mn5-20020a17090b188500b001fd66d5c42csm7022967pjb.49.2022.09.26.15.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 15:02:58 -0700 (PDT) Date: Mon, 26 Sep 2022 15:02:57 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] net/mlx5e: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper Message-ID: <202209261502.1383266E@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 04:50:42PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/222 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook