From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55416C07E9D for ; Tue, 27 Sep 2022 02:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbiI0Caw (ORCPT ); Mon, 26 Sep 2022 22:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbiI0Cat (ORCPT ); Mon, 26 Sep 2022 22:30:49 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3608EC8405 for ; Mon, 26 Sep 2022 19:30:48 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d11so7865800pll.8 for ; Mon, 26 Sep 2022 19:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=M6ZjbEpb/UdQZtA16p01zlM8hWd+9RIaPah6OiYEF9s=; b=JLnoASLUHeDPUf6dI39o1+5rs9AzhUtl9AApNwejURiKdFKySH7qwrWxoCD8281JdM s5VZBA3uCrzXB/vkhMOC5uX2WZ+020yhDkhV3nLWWe84wG1IrVbTXzd7loPubISbr7Lq REDFu0hTtFb8HmZWdQO+0sCSW2tjfT1AFwfcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=M6ZjbEpb/UdQZtA16p01zlM8hWd+9RIaPah6OiYEF9s=; b=z/EpiIGr62wqT5NJ9zZHPn+bN66Zz6D8EJK63RuYjcvLQ1Fe+NlKZ9RCzRSoWAtVZ7 xOltEe14TnIhl7QT95hurrmQzqwzXX6mgYhNoNzVzo2UVBltl+2l6pD9l/TatUHhE2yH g0eX/qARo/l68ARSUBp2IWr+PvEDZr/4+ap++a+jRNuL/Op98IxfeQf4hxYXjqRfrjM5 4fhTowYEjqO72LHtEEypkScPwLC24XSUJw/G8YMt5V+soyUa1wrbjBM4ivDpgjFSvEqD Kv3ZQRq3CrF7fZPelb1sOnkpASSf7Sx3bL6IMG/eMM4t7rp3vfYyHlYV/c4/ICQ42oa1 EV1Q== X-Gm-Message-State: ACrzQf0WYjsyX0smQiJOkb5MkgFVBR20rE7ANnTkdPMO/BDwNrGrM4+K CtfQVOZhF/JDR5a9lEj+Ce9WNQ== X-Google-Smtp-Source: AMsMyM4fVILya89l/buI/6YDmjZuGWn9S4tka+jx7icqv87/971kE+MPYocVhEp623vm5hAMuZB50Q== X-Received: by 2002:a17:90b:4c8b:b0:203:5db5:8b71 with SMTP id my11-20020a17090b4c8b00b002035db58b71mr1933594pjb.51.1664245847736; Mon, 26 Sep 2022 19:30:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t6-20020a1709027fc600b00176dc72ad88sm117601plb.287.2022.09.26.19.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 19:30:46 -0700 (PDT) Date: Mon, 26 Sep 2022 19:30:46 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] ASoC: Intel: Skylake: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper Message-ID: <202209261930.A40876B@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 05:58:17PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/226 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook