Re: [PATCH] dt-bindings: firmware: document Qualcomm SM6375 SCM

Konrad Dybcio
2022-09-21T21:07:54Z

On 21.09.2022 21:06, Krzysztof Kozlowski wrote:
> On 21/09/2022 20:43, Konrad Dybcio wrote:
>>
>>
>> On 21.09.2022 09:07, Krzysztof Kozlowski wrote:
>>> On 21/09/2022 02:10, Konrad Dybcio wrote:
>>>> Document the compatible for Qualcomm SM6375 SCM.
>>>>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>>>> ---
>>>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
>>>
>>> allOf needs to be updated.
>> Does it? I did not define this compatible in the driver, so it does
>> not consume any clocks.
>
> It's about hardware, not driver. Hardware has some clocks. If it does
> not, then you need allOf disallowing it. Otherwise what do you expect in
> the clock entries?
Ok, so if I understand correctly then, all the compatibles that are in
the long long list in /properties/compatible/enum: should also be added
somewhere in the allOf: tree?

Konrad
>
> Best regards,
> Krzysztof
>