From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B5DC6FA82 for ; Tue, 27 Sep 2022 12:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231995AbiI0Mbl (ORCPT ); Tue, 27 Sep 2022 08:31:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbiI0Mbg (ORCPT ); Tue, 27 Sep 2022 08:31:36 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE5B6EF00 for ; Tue, 27 Sep 2022 05:31:34 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id AFF0868AFE; Tue, 27 Sep 2022 14:31:30 +0200 (CEST) Date: Tue, 27 Sep 2022 14:31:30 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Christoph Hellwig , Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" Message-ID: <20220927123130.GA5549@lst.de> References: <20220915035003.3347466-1-liushixin2@huawei.com> <20220915035003.3347466-3-liushixin2@huawei.com> <20220920121305.GA4237@lst.de> <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com> <20220927072754.GB16710@lst.de> <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022 at 07:12:58PM +0800, Liu Shixin wrote: > If not do this, while some user enable swap device first and then enable zswap, > zswap will not take effect. The user need to re-enable the swap device which is > inconvenient. So load the module before swapping on, just like you'd load any driver before you expect to use it.