RE: [PATCH V7 0/2] remoteproc: support self recovery

Peng Fan
2022-09-21T02:37:50Z

> Subject: Re: [PATCH V7 0/2] remoteproc: support self recovery
>
> On Tue, Sep 20, 2022 at 06:34:18AM +0000, Peng Fan wrote:
> > Correct Bjorn's mail address.
> >
> > > Subject: RE: [PATCH V7 0/2] remoteproc: support self recovery
> > >
> > > Hi Bjorn, Mathieu
> > >
> > > It almost two and a half month until now, I not got any response.
> > > You accept or not accept or suggestion?
> > >
> > > In V6, I got a typo comment from Arnaud, then Mathieu replied
> dropped.
> > >
> > > In V7, I add A-b from Arnaud and no more response.
> > >
> > > I not understand why ignoring me.
>
> If you were subscribed to the remoteproc mailing list you would see that
> every two weeks I send an email that lists the patchsets in my queue and
> the order in which I intend to review them.
>
> That helps people know what kind of traffic maintainers currently deal with.
> If a patchset is not listed on that email it is likely because it slipped through
> the cracks, as it is the case with this set. You did not notify me and as such it
> was impossible for me to know about it.

Well. In future, I will ping you if patch is not on your list.

>
> Last but not least I do not recall you reviewing a single patchset on this list
> since the beginning of the year, which automatically negate your right to
> complain about how long it takes for patches to be reviewed.

ok, I get your point. I could help review imx specific part and
remoterpoc common part, for other soc specific support, I may not
able to help.

Thanks,
Peng.

>
> > >
> >
> > Regards,
> > Peng.
> > > Regards,
> > > Peng.
> > >
> > > > Subject: [PATCH V7 0/2] remoteproc: support self recovery
> > > >
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > V7:
> > > > Per comments from Arnaud Pouliquen:
> > > > Typo fixes
> > > > Added A-b tag
> > > >
> > > > V6:
> > > > Rename rproc_firmware_recovery to rproc_boot_recovery Drop the
> > > > unlock/lock when do reproc_attach_recovery
> > > >
> > > > V5:
> > > > Rename RPROC_FEAT_ATTACH_RECOVERY to
> > > > RPROC_FEAT_ATTACH_ON_RECOVERY Add kerneldoc for rproc
> features
> > > Change
> > > > rproc_set_feature to return int type and add a max feature check
> > > > Use __rproc_detach and __rproc_attach when do attach recovery
> > > >
> > >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > > tc
> > > > hwork.kernel.org%2Fproject%2Flinux-
> > > &amp;data=05%7C01%7Cpeng.fan%40nxp.
> > > >
> > >
> com%7C9dfde1d27090471a892208da9ab7bede%7C686ea1d3bc2b4c6fa92c
> > > d99c5c301
> > > >
> > >
> 635%7C0%7C0%7C637992411213950582%7CUnknown%7CTWFpbGZsb3d8e
> > > yJWIjoiMC4wL
> > > >
> > >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > > %7C%7C&
> > > >
> > >
> amp;sdata=LHIDdh2f%2BKYD2dJmiEqBGV0D5p4qgiay5KhvuTdDjHQ%3D&a
> > > mp;reserve
> > > > d=0 remoteproc/cover/20220615032048.465486-1-
> > > peng.fan@oss.nxp.com/
> > > >
> > > > V4:
> > > > Based on Bjorn's comments on V2-2
> > > > Move the rproc_has_feature/rproc_set_feature to
> > > > remoteproc_internal.h and Keep rproc_features still in
> > > > remoteproc.h, because we use RPROC_MAX_FEATURES to declare
> bitmap.
> > > > Update commit log for patch 2/2, and add comments
> > > >
> > > >
> > > >
> > >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > > tc
> > > > hwork.kernel.org%2Fproject%2Flinux-
> > > &amp;data=05%7C01%7Cpeng.fan%40nxp.
> > > >
> > >
> com%7C9dfde1d27090471a892208da9ab7bede%7C686ea1d3bc2b4c6fa92c
> > > d99c5c301
> > > >
> > >
> 635%7C0%7C0%7C637992411213950582%7CUnknown%7CTWFpbGZsb3d8e
> > > yJWIjoiMC4wL
> > > >
> > >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > > %7C%7C&
> > > >
> > >
> amp;sdata=LHIDdh2f%2BKYD2dJmiEqBGV0D5p4qgiay5KhvuTdDjHQ%3D&a
> > > mp;reserve
> > > > d=0 remoteproc/cover/20220323034405.976643-1-
> > > peng.fan@oss.nxp.com/
> > > >
> > > > V3:
> > > > Resend the wrong labeled patchset
> > > >
> > > >
> > >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > > tc
> > > > hwork.kernel.org%2Fproject%2Flinux-
> > > &amp;data=05%7C01%7Cpeng.fan%40nxp.
> > > >
> > >
> com%7C9dfde1d27090471a892208da9ab7bede%7C686ea1d3bc2b4c6fa92c
> > > d99c5c301
> > > >
> > >
> 635%7C0%7C0%7C637992411213950582%7CUnknown%7CTWFpbGZsb3d8e
> > > yJWIjoiMC4wL
> > > >
> > >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > > %7C%7C&
> > > >
> > >
> amp;sdata=LHIDdh2f%2BKYD2dJmiEqBGV0D5p4qgiay5KhvuTdDjHQ%3D&a
> > > mp;reserve
> > > > d=0
> > > > remoteproc/list/?series=621311
> > > >
> > > > Write a cover-letter
> > > > To i.MX8QM/QXP, they have a M4 core self-recovery capability
> > > > without Linux loading firmware. The self recovery is done by
> > > > SCU(System Control Unit). Current remoteproc framework only
> > > > support Linux help recovery remote processor(stop, loading
> > > > firmware, start). This patchset is support remote processor self
> recovery(attach recovery).
> > > >
> > > > In order to avoid introducing a new variable(bool
> > > > support_self_recovery), patch 1 introduce a new function,
> > > > rproc_has_feature to make code easy to extend, cleaner, such as we
> > > > could move "bool has_iommu" to rproc_has_feature(rproc,
> > > RPROC_FEAT_IOMMU).
> > > >
> > > > Patch 2 is introduce a new function rproc_attach_recovery for
> > > > self recovery, the original logic move to rproc_firmware_recovery
> > > > meaning needs linux to help recovery.
> > > >
> > > > V2-version 2:
> > > >
> > > >
> > >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > > tc
> > > > hwork.kernel.org%2Fproject%2Flinux-
> > > &amp;data=05%7C01%7Cpeng.fan%40nxp.
> > > >
> > >
> com%7C9dfde1d27090471a892208da9ab7bede%7C686ea1d3bc2b4c6fa92c
> > > d99c5c301
> > > >
> > >
> 635%7C0%7C0%7C637992411213950582%7CUnknown%7CTWFpbGZsb3d8e
> > > yJWIjoiMC4wL
> > > >
> > >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > > %7C%7C&
> > > >
> > >
> amp;sdata=LHIDdh2f%2BKYD2dJmiEqBGV0D5p4qgiay5KhvuTdDjHQ%3D&a
> > > mp;reserve
> > > > d=0
> > > > remoteproc/list/?series=621311
> > > > Introduce rproc_has_feature
> > > >
> > > > V2-version 1:
> > > >
> > > >
> > >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > > tc
> > > > hwork.kernel.org%2Fproject%2Flinux-
> > > &amp;data=05%7C01%7Cpeng.fan%40nxp.
> > > >
> > >
> com%7C9dfde1d27090471a892208da9ab7bede%7C686ea1d3bc2b4c6fa92c
> > > d99c5c301
> > > >
> > >
> 635%7C0%7C0%7C637992411213950582%7CUnknown%7CTWFpbGZsb3d8e
> > > yJWIjoiMC4wL
> > > >
> > >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > > %7C%7C&
> > > >
> > >
> amp;sdata=LHIDdh2f%2BKYD2dJmiEqBGV0D5p4qgiay5KhvuTdDjHQ%3D&a
> > > mp;reserve
> > > > d=0 remoteproc/patch/20220126085120.3397450-1-
> > > peng.fan@oss.nxp.com/
> > > > Nothing change in V2.
> > > > Only move this patch out from
> > > >
> > > >
> > >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > > tc
> > > > hwork.kernel.org%2Fproject%2Flinux-
> > > &amp;data=05%7C01%7Cpeng.fan%40nxp.
> > > >
> > >
> com%7C9dfde1d27090471a892208da9ab7bede%7C686ea1d3bc2b4c6fa92c
> > > d99c5c301
> > > >
> > >
> 635%7C0%7C0%7C637992411213950582%7CUnknown%7CTWFpbGZsb3d8e
> > > yJWIjoiMC4wL
> > > >
> > >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > > %7C%7C&
> > > >
> > >
> amp;sdata=LHIDdh2f%2BKYD2dJmiEqBGV0D5p4qgiay5KhvuTdDjHQ%3D&a
> > > mp;reserve
> > > > d=0
> > > > remoteproc/list/?series=604364
> > > >
> > > >
> > > > Peng Fan (2):
> > > > remoteproc: introduce rproc features
> > > > remoteproc: support attach recovery after rproc crash
> > > >
> > > > drivers/remoteproc/remoteproc_core.c | 62 ++++++++++++++++-----
> ---
> > > > drivers/remoteproc/remoteproc_internal.h | 15 ++++++
> > > > include/linux/remoteproc.h | 16 ++++++
> > > > 3 files changed, 74 insertions(+), 19 deletions(-)
> > > >
> > > > --
> > > > 2.25.1
> >