From: Stephen Boyd <sboyd@kernel.org>
To: Jiri Slaby <jslaby@suse.cz>, mturquette@baylibre.com
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
linux-clk@vger.kernel.org, Martin Liska <mliska@suse.cz>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH -resend v2] clk: pistachio: Fix initconst confusion
Date: Wed, 28 Sep 2022 18:35:03 -0700 [thread overview]
Message-ID: <20220929013505.81B0AC433D6@smtp.kernel.org> (raw)
In-Reply-To: <20220920055838.22637-1-jslaby@suse.cz>
Quoting Jiri Slaby (2022-09-19 22:58:38)
> From: Andi Kleen <ak@linux.intel.com>
>
> A variable pointing to const isn't const itself. It has to contain
> "const" keyword after "*" too. So to keep it in __initconst (and not
> mark properly as __initdata), add the "const" keyword exactly there.
>
> Note we need to update struct pistachio_mux too. On the other hand, the
> clk core already counts with "const char *const" already.
>
> [js] more explanatory commit message.
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-clk@vger.kernel.org
> Cc: Martin Liska <mliska@suse.cz>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
Applied to clk-next
prev parent reply other threads:[~2022-09-29 1:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 5:58 [PATCH -resend v2] clk: pistachio: Fix initconst confusion Jiri Slaby
2022-09-29 1:35 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929013505.81B0AC433D6@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=ak@linux.intel.com \
--cc=jslaby@suse.cz \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mliska@suse.cz \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox